Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
jo-sm
left a comment
There was a problem hiding this comment.
A couple questions from my side:
- If someone writes the phrase in a comment in PR A, and that PR gets closed, will then PR B require the phrase again?
- Is there a way to allowlist us who are in the organization? I don't see anything about it in the PR (maybe the action takes care of it?), but I think it would be a bit cumbersome if anyone who does something in the CLI who's working for Tower has to sign off first.
Yeah until Versioning the file also makes it trivially auditable, which I like.
I don't see a feature for this in the upstream. I'll attach a file to this PR with everyone in it already, and we'll just need to remember to do that as part of onboarding at Tower. Also, we'll get reminders, obviously, in the PRs that people open... |
konstantinoscs
left a comment
There was a problem hiding this comment.
Just two things on my side:
cla.jsontargets main but at the same time main is protected. Shouldn't CLAs go through the develop -> main route like everything else?- We should require the CLA on develop, not main. That's where contributions will be
Also, funny enough, I think that the way we check for the "agreement" can be tricked with a phrase like “I hereby sign … but I do not agree” which will be accepted
|
Ah it looks like the action will directly update With regard to where the CLA is required, it's basically everywhere: We don't set a target branch. Claude's developed a solution to your poisoned comment topic, too. Good find. |
|
Re-read the updated version — app-token routing via
Also, now that (Still no |
konstantinoscs
left a comment
There was a problem hiding this comment.
Lgtm!
Also, two comments from Sol, not very important to me to block on but I leave them here:
-
Add set -euo pipefail before the allowlist pipeline so API/decoding failures cannot silently produce an empty list.
-
Confirm the company rename: the PR changes the license to GmbH, while pyproject.toml and flake.nix still say Inc.
Adds a Contributor License Agreement requirement for pull requests.
CLA.md: individual CLA based on the Apache ICLA v2.2, with open items marked for legal review.github/workflows/cla.yml: CLA Assistant Lite workflow (pinned to v2.6.1 by commit SHA); signatures are stored in-repo undersignatures/version1/CONTRIBUTING.md: short section explaining the signing flowNote: the workflow uses
pull_request_target, so enforcement only takes effect once this reachesmain. Making the CLA status check required onmain(branch protection) is a separate manual step.