Skip to content

Adding drop table feature for tower tables - #99

Merged
sammuti merged 4 commits into
developfrom
feat/tower-tables-support-drop
Sep 17, 2025
Merged

Adding drop table feature for tower tables#99
sammuti merged 4 commits into
developfrom
feat/tower-tables-support-drop

Conversation

@sammuti

@sammuti sammuti commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding drop table feature for tower tables as I noticed it was missing when trying to update the tower-apps

@github-actions

github-actions Bot commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

⚠️ WARNING: This PR targets main instead of develop

This PR is targeting main which will trigger a production deployment when merged.

If this is a regular feature/fix PR, please change the base branch to develop.
If this is intentional (e.g., hotfix), you can ignore this warning.

Current base: main
Recommended base: develop

@github-actions

github-actions Bot commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

⚠️ WARNING: This PR targets main instead of develop

This PR is targeting main which will trigger a production deployment when merged.

If this is a regular feature/fix PR, please change the base branch to develop.
If this is intentional (e.g., hotfix), you can ignore this warning.

Current base: main
Recommended base: develop

@sammuti
sammuti changed the base branch from main to develop September 16, 2025 16:10
@sammuti
sammuti marked this pull request as ready for review September 17, 2025 08:04
bradhe
bradhe requested changes Sep 17, 2025
View reviewed changes

@bradhe bradhe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick discussion point!

Comment thread src/tower/_tables.py Resolved
bradhe
bradhe approved these changes Sep 17, 2025
View reviewed changes

@bradhe bradhe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after CI passes

@sammuti
sammuti merged commit 07ff48a into develop Sep 17, 2025
4 checks passed
@sammuti
sammuti deleted the feat/tower-tables-support-drop branch September 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradhe bradhe bradhe approved these changes
@datancoffee datancoffee Awaiting requested review from datancoffee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sammuti @bradhe @konstantinoscs