Repository navigation
🧪 test: tolerate a preloaded sqlite3 - #894
Merged
Merged
Conversation
The FreeBSD environment in #864 loads sqlite3 before filelock through a site hook, so the lazy-import check reported ['sqlite3'] although filelock never imported it, and the missing-sqlite3 checks could not hide a module that was already cached. The lazy-import check now counts only the modules the import adds, and the missing-module checks evict a preloaded sqlite3 before installing the finder that hides it.
gaborbernat
added
the
skip news
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FreeBSD run in #864 failed
test_lazy_import_skips_asyncio_and_sqlite3with['sqlite3']: a site hook in that environment loadedsqlite3at interpreter start, before filelock was imported. A.pthfile that importssqlite3reproduces it, and the same preload breaks the missing-sqlite3checks, because a finder cannot hide a module that is already cached.The lazy-import check now counts only the modules that importing filelock adds, and the missing-module checks evict a preloaded
sqlite3before installing the finder that hides it. Library behavior is unchanged.