Skip to content

🐛 fix(publish-github-release): match stored asset names #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaborbernat merged 1 commit into from
Oct 27, 2026
Merged

🐛 fix(publish-github-release): match stored asset names #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/+release-asset-names.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Match release assets by the name GitHub stores, which replaces characters such as spaces with periods. A file named
`PyVenv Manage 2-2.4.7-signed.zip` uploaded, but its draft stayed unpublished because the check expected the local name.
3 changes: 3 additions & 0 deletions publish-github-release/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ runs:
shopt -s nullglob dotglob
: >"$RUNNER_TEMP/release-assets.tsv"
for asset in "$ASSETS_DIRECTORY"/*; do
# GitHub stores an uploaded asset under its file name with each other character replaced by a period.
name=${asset##*/}
name=${name//[^A-Za-z0-9._+-]/.}
printf '%s\tsha256:%s\n' "$name" "$(sha256sum "$asset" | cut -d' ' -f1)" \
>>"$RUNNER_TEMP/release-assets.tsv"
done
Expand Down Expand Up @@ -149,6 +151,7 @@ runs:
present=0
for asset in "$ASSETS_DIRECTORY"/*; do
name=${asset##*/}
name=${name//[^A-Za-z0-9._+-]/.}
if jq -e --arg name "$name" --slurpfile assets "$RUNNER_TEMP/release-assets.json" '
any(.[0].assets[]; .name == $name and .state == "uploaded" and
(.digest as $digest | any($assets[0][]; .name == $name and .digest == $digest)))
Expand Down
3 changes: 2 additions & 1 deletion tests/publish_github_release/test_publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ def test_draft_release_uploads_missing_asset(
assets.mkdir()
asset_path = assets / asset_name
asset_path.write_bytes(b"release archive")
asset = {"name": asset_name, "digest": f"sha256:{sha256(b'release archive').hexdigest()}", "state": "uploaded"}
stored = asset_name.replace(" ", ".")
asset = {"name": stored, "digest": f"sha256:{sha256(b'release archive').hexdigest()}", "state": "uploaded"}
draft = _release(notes, draft=True)
complete = _release(notes, draft=True, assets=[asset])
prefix = "/api/v3/repos/tox-dev/fixture"
Expand Down