Skip to content

fix: ignore incomplete UNC folder overrides on Windows - #647

Open
RedCat888 wants to merge 2 commits into
tox-dev:mainfrom
RedCat888:fix/incomplete-unc-overrides
Open

RedCat888 wants to merge 2 commits into
tox-dev:mainfrom
RedCat888:fix/incomplete-unc-overrides

Conversation

@RedCat888

Copy link
Copy Markdown

WIN_PD_OVERRIDE_LOCAL_APPDATA=\\server is accepted even though the UNC volume has no share name. Windows("app", appauthor=False).user_data_dir then returns \\server\app, treating the application name as the share instead of falling back to the normal folder.

Require both server and share components for ordinary UNC overrides. Keep valid drive-rooted, UNC, and extended Windows paths working, and document the fallback. This follows the Windows UNC path format.

Validation on native Windows:

  • Four new incomplete-UNC cases fail on the base revision and pass with the fix.
  • Full suite on Python 3.13.11 and 3.14.2: 2,048 passed, 350 skipped each.
  • Windows suite on Python 3.11.14: 208 passed, 20 skipped.
  • Changed-line coverage: 100%; ty check src tests, pre-commit checks for changed files, and sphinx -W -b html pass.

Implemented and tested with Codex assistance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant