refactor(run-engine,webapp): route TaskRun writes through a new RunStore adapter#3981
Draft
d-cs wants to merge 19 commits into
Draft
refactor(run-engine,webapp): route TaskRun writes through a new RunStore adapter#3981d-cs wants to merge 19 commits into
d-cs wants to merge 19 commits into
Conversation
Replaces the seven throwing stubs on PostgresRunStore with verbatim relocations of the Prisma statements from runAttemptSystem: startAttempt, completeAttemptSuccess, recordRetryOutcome, requeueRun, recordBulkActionMembership, cancelRun, and failRunPermanently. Each method splices the caller-supplied select/include into the Prisma call. Tests use real Postgres containers and cover each method including edge cases (append semantics, conditional fields in cancelRun).
…y-clear, and array-append methods
Replaces the seven throwing stubs in PostgresRunStore with verbatim-relocated
Prisma statements sourced from delayedRunSystem, debounceSystem, updateMetadata,
idempotencyKeys, resetIdempotencyKey, batchTriggerV3, and the realtime-stream
route handlers.
- rescheduleRun: writes delayUntil always; queueTimestamp when provided; nested
DELAYED executionSnapshot when snapshot arg provided
- enqueueDelayedRun: sets status PENDING + queuedAt
- rewriteDebouncedRun: pass-through update with associatedWaitpoint include
- updateMetadata: optimistic-lock path (updateMany with version predicate) or
direct path (update without predicate); both return { count }
- clearIdempotencyKey: three discriminated-union branches — byId clears both
columns, byPredicate clears both, byFriendlyIds clears only idempotencyKey
- pushTags: push-append to runTags array; returns { updatedAt }
- pushRealtimeStream: push-append to realtimeStreams array; returns void
…bapp BaseService Add RunStore field to SystemResources, instantiate PostgresRunStore in RunEngine constructor (after prisma/readOnlyPrisma are set), and expose it on the resources object passed to all systems. Create a webapp singleton (runStore.server.ts) and thread it as a default parameter into BaseService so subclasses can access it without changes.
…eave-unchanged semantics)
…s through RunStore
… debounce writes through RunStore
… writes through RunStore
|
Contributor
WalkthroughThis PR introduces a new 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
internal-packages/run-store/tsconfig.build.json (1)
7-7: ⚡ Quick winRemove DOM-related type libraries from the lib array.
This is a Node.js backend package for database persistence, not a browser environment. Including
"DOM","DOM.Iterable", and"DOM.AsyncIterable"exposes browser-only APIs (e.g.,window,document) that should not be available in this package. This can lead to type confusion or code that compiles but fails at runtime.📝 Proposed fix
- "lib": ["ES2020", "DOM", "DOM.Iterable", "DOM.AsyncIterable"], + "lib": ["ES2020"],internal-packages/run-store/tsconfig.src.json (1)
7-7: ⚡ Quick winRemove DOM-related type libraries from the lib array.
This is a Node.js backend package for database persistence, not a browser environment. Including
"DOM","DOM.Iterable", and"DOM.AsyncIterable"exposes browser-only APIs (e.g.,window,document) that should not be available in this package. This can lead to type confusion or code that compiles but fails at runtime.📝 Proposed fix
- "lib": ["ES2020", "DOM", "DOM.Iterable", "DOM.AsyncIterable"], + "lib": ["ES2020"],internal-packages/run-store/tsconfig.test.json (1)
7-7: ⚡ Quick winRemove DOM-related type libraries from the lib array.
This is a Node.js backend package for database persistence, not a browser environment. Including
"DOM","DOM.Iterable", and"DOM.AsyncIterable"exposes browser-only APIs (e.g.,window,document) that should not be available in this package. This can lead to type confusion or code that compiles but fails at runtime.📝 Proposed fix
- "lib": ["ES2020", "DOM", "DOM.Iterable", "DOM.AsyncIterable"], + "lib": ["ES2020"],
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1e3ea550-db9d-4872-8509-ad61e20dacdd
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (32)
apps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/services/metadata/updateMetadata.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/package.jsoninternal-packages/run-engine/package.jsoninternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/systems/systems.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsinternal-packages/run-store/package.jsoninternal-packages/run-store/src/NoopRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/index.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/tsconfig.build.jsoninternal-packages/run-store/tsconfig.jsoninternal-packages/run-store/tsconfig.src.jsoninternal-packages/run-store/tsconfig.test.jsoninternal-packages/run-store/vitest.config.mts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (14)
**/tsconfig.json
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use strict mode in TypeScript configuration
Files:
internal-packages/run-store/tsconfig.json
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
internal-packages/run-store/tsconfig.jsonapps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/tsconfig.build.jsoninternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsinternal-packages/run-store/tsconfig.src.jsoninternal-packages/run-store/tsconfig.test.jsonapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-store/package.jsoninternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/package.jsoninternal-packages/run-engine/package.jsoninternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/services/metadata/updateMetadata.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/services/metadata/updateMetadata.server.ts
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/services/metadata/updateMetadata.server.ts
internal-packages/run-engine/src/engine/systems/**/*.ts
📄 CodeRabbit inference engine (internal-packages/run-engine/CLAUDE.md)
Integrate OpenTelemetry tracer and meter instrumentation in RunEngine systems for observability
Files:
internal-packages/run-engine/src/engine/systems/systems.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.ts
apps/webapp/{app/v3/services/triggerTask.server.ts,app/v3/services/batchTriggerV3.server.ts}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In
triggerTask.server.tsandbatchTriggerV3.server.ts, do NOT add database queries. Task defaults (TTL, etc.) are resolved viabackgroundWorkerTask.findFirst()in the queue concern (queues.server.ts). Piggyback on the existing query instead of adding new ones
Files:
apps/webapp/app/v3/services/batchTriggerV3.server.ts
apps/webapp/app/v3/services/{cancelTaskRun,batchTriggerV3}.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
When editing services that branch on
RunEngineVersionto support both V1 and V2 (e.g.,cancelTaskRun.server.ts,batchTriggerV3.server.ts), only modify V2 code paths
Files:
apps/webapp/app/v3/services/batchTriggerV3.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/run-store/src/PostgresRunStore.test.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Never mock anything in tests - use testcontainers instead
Test files should be placed next to source files (e.g.,MyService.ts->MyService.test.ts)
Files:
internal-packages/run-store/src/PostgresRunStore.test.ts
**/*.test.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{js,ts,tsx}: Test files should live beside the files under test and use descriptivedescribeanditblocks
Use vitest for unit testing
Tests should avoid mocks or stubs and use helpers from@internal/testcontainerswhen Redis or Postgres are needed
Files:
internal-packages/run-store/src/PostgresRunStore.test.ts
🧠 Learnings (19)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/services/metadata/updateMetadata.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.tsapps/webapp/app/services/metadata/updateMetadata.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/v3/runStore.server.tsinternal-packages/run-store/src/index.tsapps/webapp/app/v3/services/rescheduleTaskRun.server.tsinternal-packages/run-store/src/NoopRunStore.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.tsinternal-packages/run-engine/src/engine/systems/systems.tsapps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/concerns/idempotencyKeys.server.tsapps/webapp/app/routes/api.v1.runs.$runId.tags.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsinternal-packages/run-engine/src/engine/systems/delayedRunSystem.tsinternal-packages/run-engine/src/engine/systems/checkpointSystem.tsinternal-packages/run-engine/src/engine/systems/pendingVersionSystem.tsinternal-packages/run-engine/src/engine/systems/debounceSystem.tsapps/webapp/app/v3/services/baseService.server.tsinternal-packages/run-engine/src/engine/systems/ttlSystem.tsapps/webapp/app/services/metadata/updateMetadata.server.tsinternal-packages/run-engine/src/engine/systems/dequeueSystem.tsinternal-packages/run-store/src/types.tsinternal-packages/run-engine/src/engine/systems/runAttemptSystem.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.
Applied to files:
apps/webapp/app/v3/services/rescheduleTaskRun.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/services/resetIdempotencyKey.server.tsapps/webapp/app/v3/services/baseService.server.ts
📚 Learning: 2026-04-27T16:46:03.861Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3456
File: apps/webapp/package.json:152-152
Timestamp: 2026-04-27T16:46:03.861Z
Learning: In `apps/webapp/package.json`, treat the `effect` npm package as an intentional runtime dependency (not unused/misplaced) for the Schedule + Fiber-based metadata update logic. This should apply when reviewing `apps/webapp` code paths used by `apps/webapp/app/utils/updateMetadata.server.ts` (and closely related modules) that use Effect APIs such as `Duration.divide`, `STM.cond`, namespace exports for `Effect`/`Schedule`/`Duration`/`Fiber`, and the `Fiber.RuntimeFiber` type.
Applied to files:
apps/webapp/package.json
📚 Learning: 2025-12-18T14:09:01.965Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 2794
File: internal-packages/run-engine/src/engine/systems/debounceSystem.ts:390-397
Timestamp: 2025-12-18T14:09:01.965Z
Learning: In internal-packages/run-engine/src/engine/systems/debounceSystem.ts, do not allow debounce delays shorter than 1 second. The parseNaturalLanguageDuration function currently supports only weeks, days, hours, minutes, and seconds (w/d/hr/h/m/s). Millisecond delays are not supported. Update any input validation, error messages, and related tests to reflect a minimum 1s debounce and restrict inputs to the supported units.
Applied to files:
internal-packages/run-engine/src/engine/systems/debounceSystem.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/metadata/updateMetadata.server.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.test.ts
🔇 Additional comments (52)
internal-packages/run-engine/src/engine/systems/systems.ts (1)
1-25: LGTM!internal-packages/run-engine/src/engine/index.ts (7)
76-76: LGTM!
106-106: LGTM!
128-128: LGTM!
316-330: LGTM!
539-617: LGTM!
833-933: LGTM!
1178-1211: LGTM!internal-packages/run-engine/src/engine/systems/checkpointSystem.ts (1)
118-131: LGTM!Also applies to: 295-312
internal-packages/run-engine/src/engine/systems/dequeueSystem.ts (1)
422-458: LGTM!Also applies to: 730-755
internal-packages/run-engine/src/engine/systems/pendingVersionSystem.ts (1)
132-132: LGTM!internal-packages/run-engine/src/engine/systems/ttlSystem.ts (1)
3-3: LGTM!Also applies to: 64-108, 231-231
internal-packages/run-engine/src/engine/systems/delayedRunSystem.ts (1)
51-63: LGTM!Also applies to: 174-180
internal-packages/run-engine/src/engine/systems/debounceSystem.ts (1)
1163-1163: LGTM!internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts (7)
400-460: LGTM!
743-794: LGTM!
1000-1019: LGTM!
1254-1264: LGTM!
1340-1340: LGTM!
1393-1436: LGTM!
1605-1650: LGTM!internal-packages/run-store/src/PostgresRunStore.test.ts (4)
1-77: LGTM!
79-931: LGTM!
933-1019: LGTM!
1021-1483: LGTM!internal-packages/run-store/src/NoopRunStore.ts (1)
1-32: LGTM!internal-packages/run-store/src/index.ts (1)
1-3: LGTM!apps/webapp/app/v3/runStore.server.ts (1)
1-8: LGTM!apps/webapp/app/v3/services/baseService.server.ts (1)
2-2: LGTM!Also applies to: 7-7, 15-16
apps/webapp/app/v3/services/batchTriggerV3.server.ts (1)
411-414: LGTM!apps/webapp/app/routes/api.v1.runs.$runId.tags.ts (1)
12-12: LGTM!Also applies to: 88-88
apps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.append.ts (1)
9-9: LGTM!Also applies to: 91-91
apps/webapp/app/routes/realtime.v1.streams.$runId.$target.$streamId.ts (1)
9-9: LGTM!Also applies to: 90-90
apps/webapp/app/v3/services/rescheduleTaskRun.server.ts (1)
20-27: LGTM!apps/webapp/app/v3/services/resetIdempotencyKey.server.ts (1)
12-21: LGTM!Also applies to: 77-86
apps/webapp/app/runEngine/concerns/idempotencyKeys.server.ts (1)
13-13: LGTM!Also applies to: 194-197, 211-214
apps/webapp/app/services/metadata/updateMetadata.server.ts (1)
16-17: LGTM!Also applies to: 29-29, 55-55, 64-64, 268-277, 476-488, 570-582
internal-packages/run-store/package.json (1)
1-31: LGTM!internal-packages/run-store/tsconfig.json (1)
1-8: LGTM!internal-packages/run-store/vitest.config.mts (1)
1-11: LGTM!apps/webapp/package.json (1)
64-64: LGTM!internal-packages/run-engine/package.json (1)
24-24: LGTM!internal-packages/run-store/src/types.ts (10)
1-10: LGTM!
12-70: LGTM!
72-81: LGTM!
84-143: LGTM!
145-188: LGTM!
207-216: LGTM!
218-221: LGTM!
223-223: LGTM!
225-321: LGTM!
190-205: Type signature is correct—callers explicitly provide all properties.The
maxDurationInSeconds: number | null | undefinedsignature matches actual usage. Both call sites explicitly pass this property: the test passesnull, anddequeueSystem.tspasses the variable directly. The required field with undefined in the union is intentional design—it distinguishes between a caller omitting the field versus explicitly setting it toundefined. The same pattern applies tomaxAttempts, confirming this is consistent across the codebase.
Comment on lines
+331
to
+346
| async expireRunsBatch( | ||
| runIds: string[], | ||
| data: { error: TaskRunError; now: Date }, | ||
| tx?: PrismaClientOrTransaction | ||
| ): Promise<number> { | ||
| const prisma = tx ?? this.prisma; | ||
|
|
||
| return prisma.$executeRaw` | ||
| UPDATE "TaskRun" | ||
| SET "status" = 'EXPIRED'::"TaskRunStatus", | ||
| "completedAt" = ${data.now}, | ||
| "expiredAt" = ${data.now}, | ||
| "updatedAt" = ${data.now}, | ||
| "error" = ${JSON.stringify(data.error)}::jsonb | ||
| WHERE "id" IN (${Prisma.join(runIds)}) | ||
| `; |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all call sites and confirm whether caller-side non-empty guards already exist.
rg -nP --type=ts -C4 '\bexpireRunsBatch\s*\('Repository: triggerdotdev/trigger.dev
Length of output: 9698
🏁 Script executed:
# Check the ttlSystem.expireRunsBatch implementation and its call to store method
sed -n '156,240p' internal-packages/run-engine/src/engine/systems/ttlSystem.tsRepository: triggerdotdev/trigger.dev
Length of output: 2801
🏁 Script executed:
# Check the test that calls with empty array
sed -n '1650,1665p' internal-packages/run-engine/src/engine/tests/ttl.test.tsRepository: triggerdotdev/trigger.dev
Length of output: 431
🏁 Script executed:
# Check if there's any guard before the call at line 231
sed -n '220,240p' internal-packages/run-engine/src/engine/systems/ttlSystem.tsRepository: triggerdotdev/trigger.dev
Length of output: 838
🏁 Script executed:
# Search for all calls to runStore.expireRunsBatch (not just ttlSystem wrapper)
rg -n "runStore\.expireRunsBatch" --type=tsRepository: triggerdotdev/trigger.dev
Length of output: 228
🏁 Script executed:
# Also check if Prisma.join with empty array is actually problematic
# Look for any usage patterns or documentation
rg -n "Prisma\.join" --type=ts -B2 -A2 | head -50Repository: triggerdotdev/trigger.dev
Length of output: 4340
🏁 Script executed:
# Check if RunStore interface is imported and used elsewhere
rg -n "RunStore\b" --type=ts -g "!*.test.ts" | grep -E "(import|extends|implements)" | head -20Repository: triggerdotdev/trigger.dev
Length of output: 1159
🏁 Script executed:
# Check for any direct instantiation or usage of PostgresRunStore outside ttlSystem
rg -n "new PostgresRunStore|PostgresRunStore\(" --type=ts | grep -v testRepository: triggerdotdev/trigger.dev
Length of output: 333
Add guard for empty runIds array before executing raw query.
The method should return 0 early if runIds is empty to prevent generating invalid SQL (WHERE "id" IN ()). While the current caller (ttlSystem) guards before calling this method, the public interface should be defensively programmed and not depend on caller discipline.
Proposed fix
async expireRunsBatch(
runIds: string[],
data: { error: TaskRunError; now: Date },
tx?: PrismaClientOrTransaction
): Promise<number> {
const prisma = tx ?? this.prisma;
+ if (runIds.length === 0) {
+ return 0;
+ }
return prisma.$executeRaw`
UPDATE "TaskRun"
SET "status" = 'EXPIRED'::"TaskRunStatus",
"completedAt" = ${data.now},
"expiredAt" = ${data.now},
"updatedAt" = ${data.now},
"error" = ${JSON.stringify(data.error)}::jsonb
WHERE "id" IN (${Prisma.join(runIds)})
`;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
@internal/run-store, a typed write layer that every TaskRun write now goes through, and routes the existing directprisma.taskRun.*writes across the run engine and webapp onto it. This is a behavior-preserving refactor: the same rows are written, with the same SQL, against the same table. It puts run persistence behind one interface so future storage changes have a single seam instead of dozens of scattered write sites.Design
RunStoreexposes one method per run-lifecycle write (create, dequeue lock, attempt start/complete/fail, retry, cancel, expire, checkpoint suspend and resume, delay and reschedule, debounce, metadata, idempotency-key clear, tag and stream append).PostgresRunStoreimplements each as the exact write the call site performed before, against the existingTaskRuntable. ANoopRunStoreis provided for tests.The engine reaches the store through a new field on its shared system resources; the webapp through a base-service member and a server singleton. Every method accepts an optional transaction client, so in-transaction writes are unchanged.
Behavior is covered by unit tests for each store method (real Postgres via testcontainers) and by the existing run engine suite staying green.