chore: enforce no unused deps or code in ci - #4654
Merged
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 489 files, which is 189 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (489)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
carderne
marked this pull request as ready for review
August 17, 2026 16:23
|
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
carderne
force-pushed
the
chore/knip-unused-code
branch
from
August 18, 2026 10:14
8460767 to
63a617f
Compare
nicktrn
approved these changes
Aug 18, 2026
samejr
added a commit
that referenced
this pull request
Aug 19, 2026
…them #4654's unused-code pass removed these, correctly by its own measure: each had no importer at all, and the storybook pages that document them exist only on this branch, so the pass couldn't see them. Restored deliberately, because a design-system storybook that silently omits primitives is worse than carrying a few components the product doesn't currently call. Two whole modules come back (AnimatingArrow, PrettyDuration) plus five exports whose surrounding components stayed (SmartDateTime, LiveCountUp, InputOTPSeparator, PopoverSideMenuTrigger, TableCellChevron), and their stories along with them. Every one carries a comment saying why it's kept and pointing here, so the next unused-code pass doesn't quietly take them out again - knip is satisfied either way, since a storybook route is an entry point and anything it imports counts as used. LabelValueStack is the exception and stays deleted: its only historical consumer was a test, not a page. Collateral from reverting those hunks wholesale - useLocalTimeZone, useUserTimeZone and the PopoverArrowTriggerVariant type - is kept but no longer exported, since nothing outside their own files uses them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 tasks
samejr
added a commit
that referenced
this pull request
Aug 19, 2026
…ocument them" This reverts commit 90f04957a0e60c0e4d7a51e2c0b2c1e3f4d8b7a1. #4654's unused-code cleanup stands as written. Every file it touched is now byte-identical to main again: the two modules it deleted stay deleted, the five exports it removed stay removed, and the three it merely unexported (AlertAction, SheetDescription, SheetFooter) are private again too - that last part went beyond the reverted commit, since those re-exports came in with the merge itself. The storybook stories for all of them are gone with them. This branch keeps less primitive coverage than it had, which is the cost of not carrying components the product doesn't call. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had knip installed but weren't really using it.
This PR:
Does all of these: