Repository navigation
Say "Backtalk off" with low-latency audio on - #108
Merged
Merged
Conversation
When Backtalk turned off, the sounds shut down the low-latency players just after "Backtalk off" was queued. Speech shares those players, so the announcement was stopped before it was heard, and only with Low-latency audio on. The last announcement is now spoken the usual way, through the engine's own playback, as it is with Low-latency audio off. Turning Backtalk on again reads the setting again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Low-latency audio on, "Backtalk off" was not heard when Backtalk turned off.
Pipeline.onUnbindqueues the announcement and thenActors.onUnbindshuts down the sounds, andFeedbackController.shutdown()callsLowLatencyAudio.shutdownAll(). Speech shares those players, so the announcement's stream was stopped a few milliseconds after it started, while the engine played its own copy at no volume, as it does for low-latency speech.The last announcement is now spoken the usual way, through the engine's own playback, as it is with Low-latency audio off. Turning Backtalk on again sets up speech afresh and reads the setting again.