Support adding multiple packages with add command#3378
Open
r-bt wants to merge 3 commits into
Open
Conversation
imrishabh18
approved these changes
Jun 20, 2026
mohan-bee
approved these changes
Jun 20, 2026
rushabhcodes
left a comment
Contributor
There was a problem hiding this comment.
also update in readme
Author
Done |
rushabhcodes
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While following the tutorial at: https://docs.tscircuit.com/tutorials/build-a-custom-keyboard-with-tscircuit, it says to run:
However this throws an error:
Using the variadic argument
<packageSpecs...>in the commander definition resolves this.Note that adding multiple packages through the interactive cli (i.e. running
tsciand then selecting add from the menu) did work.However, this highlighted a bug with the
addPackagefunction where it was only normalizing the first package in a list of packages. So I added a new functionaddPackageswhich normalizes all the packages, and haveaddPackagejust call that.All the existing add testcases pass, and I added a new one to verify that adding two packages works