Skip to content

Undocumented breaking change in com.twilio.rest.verify.v2.service.Verification#getSendCodeAttempts() #976

Description

@jon-signal

Somewhere between version 10.x and 13.x of twilio-java, the return type of com.twilio.rest.verify.v2.service.Verification#getSendCodeAttempts() changed from List<Map<String, Object>> to just List<Object>, but the change isn't noted anywhere in the upgrade guide. It appears that the "shape" of the returned list element is the same, and casting it to a Map<String, Object> is all that's needed.

There are several things that I think could be addressed here:

  1. The main focus of this ticket: it's probably worth calling out this change somewhere in the upgrade guide.
  2. Could getSendCodeAttempts return a more specific object type?
  3. The Javadoc for twilio-java from 11.x and up does not include any of the getter methods for Verification (and numerous other classes). It looks like the last version for which getter documentation was present is 10.9.2. I'm guessing that doc generation for 11+ is happening before some code generation step that would actually add the getters.
  4. On a related note, the published source jars for at least 13.0.0 (and I strongly suspect other versions) do not match the published bytecode.
  5. For 10.9.2 (and probably other versions), trying to actually view the docs leads to an "access denied" error.

I'm happy to open separate issues for all of these if that's helpful to you; I present them here as a single issue because they're all part of the same "trying to figure out what changed and when" story.

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions