Fix up phpstan issues and formatting in templates and setup CI to run on generated example templates.#236
Merged
sagikazarmark merged 1 commit intotwirphp:masterfrom Jan 14, 2026
Conversation
6f25d66 to
14655c5
Compare
Contributor
Author
|
Here's an execution where I made a failing change to a template: https://github.com/twirphp/twirp/actions/runs/20838658367/job/59868408300?pr=236 Here's an execution with |
Contributor
Author
|
Also lemme know if this is too large, I just sort of went down the list of reported issues on this one |
sagikazarmark
requested changes
Jan 9, 2026
Member
sagikazarmark
left a comment
There was a problem hiding this comment.
Thanks!
I had a couple comments.
… on generated example templates.
14655c5 to
b6dd2d8
Compare
sagikazarmark
approved these changes
Jan 14, 2026
Member
|
Thanks @SpencerMalone ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a style cleanup and analysis sweep of the templates to try and get them matching the code quality elsewhere.
What this PR does / why we need it
Special notes for your reviewer
Does this PR introduce a user-facing change?