Repository navigation
PLAT-1314/fix: preserve keychain lookup and deletion errors - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b0aa5862e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Puvendhan
left a comment
There was a problem hiding this comment.
LGTM. A real keychain error (anything other than ErrNotFound) now surfaces with the context name instead of looking like 'no key stored'. DeleteKey wraps it the same way. --api-key and TWO_API_KEY still bypass the keychain, and nothing falls back to a file.
Context
PLAT-1314 requires clear diagnostics when the OS keychain backend is unavailable. Credential writes already format known Linux backend failures, but reads discard every keychain failure as “no API key found,” and deletes return the raw backend error. Users are sent back to login even when their stored key cannot be read because the backend is unavailable or access is denied.
Changes
Scope / Non-goals
No credential storage backend, live credentials, or configuration-selection behavior is changed. This starts from refreshed main including externally merged #9; open #6/#8 are independent. PLAT-1314 was already Bharat-owned/In Progress, and the ownership/branch/PR audit found no competing implementation.
Validation
On exact head
57a71b9d076af2c95586e138c191b30e750ab7fb, CI run 40862351741 passed both jobs:go build ./..., embedded-spec drift verification, and all tests throughmake test-coverpassed, including the 80% coverage gate.Ticket
Refs PLAT-1314.
✨ via Codex session