Repository navigation
Splash screen: [web] port, IP address only (M7) - #243
Merged
Merged
Conversation
The built-in splash gets [web] port as its `port` setting; a reload that changes the port gives the splash the new address at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[web] port only changes at the next start (WEB_NEXT_START), so the splash keeps the port the web interface started with; the plugin's port is strict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Answers to the reviewOne review agent did all four reviews (code, tests, security, docs), since the PR is small.
Security: nothing found. Tests: 3 of 4 planted bugs were caught; the 4th (port range) now has a test. |
The web interface only accepts IP addresses, so the http://<name>.local line led to an error page. txoof chose to drop it (keep it simple). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
txoof
approved these changes
Oct 7, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242
What changed
port(default 8080, 1–65535) and uses it in both web addresses and in the QR code. The fixedWEB_PORTconstant is gone.port = [web] portfrom the config at start. Like the web interface itself ([web] portis inWEB_NEXT_START), a changed port applies at the next start of PaperPi, so the splash never shows a port the web interface isn't using.[[plugin]]block uses its ownportsetting (default 8080); the README says so.http://<name>.local:8080led to an error page. The splash now shows the IP address (larger) and the QR code; the host-name reader is removed.Why: #236 used a fixed 8080 because
[web] portdid not exist yet when it was built; it arrived with M5 part 1 (#239/#240). With another port, the splash and its QR code pointed to the wrong address.Size: +88/−107 (
git diff --shortstat origin/main...HEAD). Small on purpose: txoof asked for this fix as its own PR.Reference images for the splash changed (one address line instead of two).
Area
plugins/splash_screen, the splash part of
src/paperpi/scheduler.py, their tests. Checked: open PR #241 (M5 part 2a) also changesscheduler.py, but other lines.Tests
[web] port's default; withport = 9000both addresses and the QR code use 9000.[web] port, and keeps it after reloads (also when it draws again after a rotation change).uv run pytestpasses (1151 passed, 1 deselected; fewer because the host-name tests are gone)uv run ruff check .passesReview
Only txoof approves and merges this PR.
🤖 Generated with Claude Code