feat(platform): Add local subprocess implementation of gitworkspace.Workspace - #766
Merged
Merged
Conversation
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 1, 2026 23:20
manjari25
force-pushed
the
manjari/gitworkspace-local
branch
2 times, most recently
from
October 1, 2026 23:35
f7b5d56 to
5adce59
Compare
behinddwalls
approved these changes
Oct 2, 2026
behinddwalls
force-pushed
the
manjari/gitworkspace-local
branch
from
October 2, 2026 01:09
5adce59 to
93d97db
Compare
behinddwalls
changed the base branch from
manjari/gitworkspace-extension
to
main
October 2, 2026 01:09
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The unified merger needs a concrete
Workspacefor OSS deployments. This implementation runs git commands against a local clone, which is what the OSS git merger does today. Alternative deployments provide their own implementation wrapping their backend's exec API.What?
Adds
platform/extension/gitworkspace/local/— an implementation ofgitworkspace.Workspacethat executes command batches as local subprocesses, with skip-on-failure semantics matching the interface contract.Test Plan
bazel test //platform/extension/gitworkspace/local:go_default_test— 8 tests covering success, multi-command batches, skip-after-failure, state persistence across calls, stdin, stderr, invalid binary, and empty batchmake check-gazelle— BUILD files in syncIssue