refactor(async): drop fake-async Task.Run wrappers

test/RAPS/RAPSControllerTests.cs

@@ -68,7 +68,7 @@ public async Task RolePermissions_ReturnsView_ForValidRoleId()
             using var context = await CreateContextAsync(connection);
             var controller = CreateController(context);
 
-            var result = await controller.RolePermissions(5);
+            var result = controller.RolePermissions(5);
 
             var view = Assert.IsType<ViewResult>(result);
             Assert.Equal(5, view.ViewData["roleId"]);
@@ -215,6 +215,11 @@ public async Task GroupSync_RunsSyncInItsOwnScope_WhenGroupExists()
             scope.Received(1).Dispose();
         }
 
+        private static Task AssertBadRequestForInvalidModelStateAsync(Func<RAPSController, IActionResult> action)
+        {
+            return AssertBadRequestForInvalidModelStateAsync(c => Task.FromResult(action(c)));
+        }
+
         private static async Task AssertBadRequestForInvalidModelStateAsync(Func<RAPSController, Task<IActionResult>> action)
         {
             using var connection = await OpenConnectionAsync();

web/Areas/Directory/Controllers/DirectoryController.cs

@@ -33,19 +33,19 @@ public DirectoryController(AAUDContext aaud, RAPSContext rapsContext)
         /// Directory home page
         /// </summary>
         [Route("")]
-        public async Task<ActionResult> Index(string? useExample)
+        public ActionResult Index(string? useExample)
         {
-            return await Task.Run(() => View("~/Areas/Directory/Views/Card.cshtml"));
+            return View("~/Areas/Directory/Views/Card.cshtml");
         }
 
         /// <summary>
         /// Directory home page
         /// </summary>
         [Route("nav")]
-        public async Task<ActionResult<IEnumerable<NavMenuItem>>> Nav()
+        public ActionResult<IEnumerable<NavMenuItem>> Nav()
         {
             var nav = new List<NavMenuItem>();
-            return await Task.Run(() => nav);
+            return nav;
         }
 
 
@@ -105,12 +105,12 @@ public async Task<ActionResult<IEnumerable<IndividualSearchResult>>> GetUCD(stri
         /// <summary>
         /// Directory results
         /// </summary>
-        /// <param name="uid">User ID</param>
+        /// <param name="mothraID">Mothra ID</param>
         [Route("userInfo/{mothraID}")]
-        public async Task<IActionResult> DirectoryResult(string mothraID)
+        public IActionResult DirectoryResult(string mothraID)
         {
             // pull in the user based on uid
-            return await Task.Run(() => View("~/Areas/Directory/Views/UserInfo.cshtml"));
+            return View("~/Areas/Directory/Views/UserInfo.cshtml");
         }
 
         /// <summary>

web/Areas/Students/Services/PhotoService.cs

@@ -118,6 +118,8 @@ public async Task<bool> StudentPhotoExistsAsync(string mailId)
                 return false;
             }
 
+            // Legitimate Task.Run: File.Exists is blocking I/O (photo store may be a
+            // network share) and callers fan these checks out with Task.WhenAll.
             return await Task.Run(() =>
             {
                 var photoPath = GetPhotoPath(mailId);

web/Classes/HealthChecks/LdapHealthCheck.cs

@@ -32,6 +32,8 @@ public async Task<HealthCheckResult> CheckHealthAsync(
 
             try
             {
+                // Legitimate Task.Run: S.DS.Protocols has no async API, so the
+                // blocking LDAP bind is offloaded to keep the caller responsive.
                 await Task.Run(() =>
                 {
                     var ldapIdentifier = new LdapDirectoryIdentifier(_ldapServer, _ldapSSLPort);

web/Views/Shared/Components/CMSBlocks/CMSBlocks.cs

@@ -16,11 +16,11 @@ public CMSBlocksViewComponent(VIPERContext viperContext, RAPSContext rapsContext
             CMS = new CMS(viperContext, rapsContext, sanitizerService);
         }
 
-        public async Task<IViewComponentResult> InvokeAsync(int? contentBlockID, string? friendlyName, string? system, string? viperSectionPath, string? page, int? blockOrder, bool? allowPublicAccess, int? status)
+        public IViewComponentResult Invoke(int? contentBlockID, string? friendlyName, string? system, string? viperSectionPath, string? page, int? blockOrder, bool? allowPublicAccess, int? status)
         {
             List<ContentBlock>? blocks = CMS.GetContentBlocksAllowed(contentBlockID, friendlyName, system, viperSectionPath, page, blockOrder, allowPublicAccess, status)?.ToList();
 
-            return await Task.Run(() => View("Default", blocks));
+            return View("Default", blocks);
         }
 
     }

web/Views/Shared/Components/EmulationBanner/EmulationBanner.cs

@@ -5,16 +5,16 @@ namespace Viper.Views.Shared.Components.EmulationBanner
     [ViewComponent(Name = "EmulationBanner")]
     public class EmulationBannerViewComponent : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync()
+        public IViewComponentResult Invoke()
         {
             IUserHelper UserHelper = new UserHelper();
             if (!UserHelper.IsEmulating())
             {
-                return await Task.Run(() => (IViewComponentResult)Content(string.Empty));
+                return Content(string.Empty);
             }
 
             string? displayFullName = UserHelper.GetCurrentUser()?.DisplayFullName;
-            return await Task.Run(() => View("Default", displayFullName));
+            return View("Default", displayFullName);
         }
     }
 }

web/Views/Shared/Components/LeftNav/LeftNav.cs

@@ -6,12 +6,12 @@ namespace Viper.Views.Shared.Components.LeftNav
     [ViewComponent(Name = "LeftNav")]
     public class LeftNavViewComponent : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync(AaudUser user, int nav)
+        public IViewComponentResult Invoke(AaudUser user, int nav)
         {
 
 
 
-            return await Task.Run(() => View("Default", user));
+            return View("Default", user);
         }
 
     }

web/Views/Shared/Components/MainNav/MainNav.cs

@@ -40,7 +40,7 @@ public MainNavViewComponent(RAPSContext context)
             _context = context;
         }
 
-        public async Task<IViewComponentResult> InvokeAsync(AaudUser user)
+        public IViewComponentResult Invoke(AaudUser user)
         {
             ViewData["OldViperURL"] = oldViperURL;
             var userHelper = new UserHelper();
@@ -67,7 +67,7 @@ public async Task<IViewComponentResult> InvokeAsync(AaudUser user)
                 "scheduler" => "Computing",
                 _ => "VIPER Home",
             };
-            return await Task.Run(() => View("Default", user));
+            return View("Default", user);
         }
 
     }

web/Views/Shared/Components/MiniNav/MiniNav.cs

@@ -8,10 +8,10 @@ public class MiniNavViewComponent : ViewComponent
     {
         private readonly string oldViperURL = HttpHelper.GetOldViperRootURL();
 
-        public async Task<IViewComponentResult> InvokeAsync(AaudUser user)
+        public IViewComponentResult Invoke(AaudUser user)
         {
             ViewData["OldViperURL"] = oldViperURL;
-            return await Task.Run(() => View("Default", user));
+            return View("Default", user);
         }
 
     }

web/Views/Shared/Components/ProfilePic/ProfilePic.cs

@@ -14,12 +14,12 @@ public ProfilePicViewComponent(AAUDContext context)
             _AAUDContext = context;
         }
 
-        public async Task<IViewComponentResult> InvokeAsync(string? userName)
+        public IViewComponentResult Invoke(string? userName)
         {
             IUserHelper UserHelper = new UserHelper();
             AaudUser? user = UserHelper.GetByLoginId(_AAUDContext, userName);
 
-            return await Task.Run(() => View("Default", user));
+            return View("Default", user);
         }
 
     }

web/Views/Shared/Components/SessionTimeout/SessionTimeout.cs

@@ -5,7 +5,7 @@ namespace Viper.Views.Shared.Components.SessionTimeout
     [ViewComponent(Name = "SessionTimeout")]
     public class SessionTimeout : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync()
+        public IViewComponentResult Invoke()
         {
             UserHelper userHelper = new UserHelper();
             string? loginId = userHelper.GetCurrentUser()?.LoginId;
@@ -14,7 +14,7 @@ public async Task<IViewComponentResult> InvokeAsync()
                 + "/public/timeout/seconds_until_timeout_v2.cfm?id="
                 + (loginId ?? "")
                 + "&service=" + (onDev ? "Viper2-dev" : "Viper2");
-            return await Task.Run(() => View("Default"));
+            return View("Default");
         }
 
     }

web/Views/Shared/Components/VueCdn/VueCdnCreate.cs

@@ -5,9 +5,9 @@ namespace Viper.Views.Shared.Components.VueCdn
     [ViewComponent(Name = "VueCdnCreate")]
     public class VueCdnCreate : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync()
+        public IViewComponentResult Invoke()
         {
-            return await Task.Run(() => View("~/Views/Shared/Components/VueCdn/VueCdnCreate.cshtml"));
+            return View("~/Views/Shared/Components/VueCdn/VueCdnCreate.cshtml");
         }
     }
 }

web/Views/Shared/Components/VueCdn/VueCdnInit.cs

@@ -5,9 +5,9 @@ namespace Viper.Views.Shared.Components.VueCdn
     [ViewComponent(Name = "VueCdnInit")]
     public class VueCdnInit : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync()
+        public IViewComponentResult Invoke()
         {
-            return await Task.Run(() => View("~/Views/Shared/Components/VueCdn/VueCdnInit.cshtml"));
+            return View("~/Views/Shared/Components/VueCdn/VueCdnInit.cshtml");
         }
 
     }

web/Views/Shared/Components/VueTableDefault/VueTableDefault.cs

@@ -8,7 +8,7 @@ namespace Viper.Views.Shared.Components.VueTableDefault
 
     public class VueTableDefaultViewComponent : ViewComponent
     {
-        public async Task<IViewComponentResult> InvokeAsync(IEnumerable<Object>? data, string keyColumnName,
+        public IViewComponentResult Invoke(IEnumerable<Object>? data, string keyColumnName,
              IEnumerable<string>? skipColumns = null, IEnumerable<Tuple<string, string>>? altColumnNames = null,
              IEnumerable<string>? skipColumnsVisible = null
              )
@@ -25,7 +25,7 @@ public async Task<IViewComponentResult> InvokeAsync(IEnumerable<Object>? data, s
             ViewData["Rows"] = GetDefaultRows(dataList, skipList);
             ViewData["VisibleColumns"] = GetDefaultVisibleColumns(dataList, skipVisibleList);
 
-            return await Task.Run(() => View("Default"));
+            return View("Default");
         }
 
         #region public static string GetDefaultColumnNames(IEnumerable<Object>? data, IEnumerable<string>? skipColumns = null, IEnumerable<Tuple<string,string>>? altColumnNames = null)