CI: add permissions, a concurrency group, and SHA-pin actions - #76
Open
emirhan-karaca wants to merge 1 commit into
Open
emirhan-karaca wants to merge 1 commit into
emirhan-karaca wants to merge 1 commit into
Conversation
Closes unlayer#33. - Add top-level permissions: contents: read - Add top-level concurrency group to cancel superseded PR runs while protecting queued main runs - Pin all 7 action references across checks, demo, and test jobs to full commit SHAs with version comments
|
@emirhan-karaca is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Summary of Changes
This PR applies three GitHub Actions CI hardening and efficiency enhancements to
.github/workflows/ci.yml:Top-Level
permissionsDeclaration:permissions: contents: readat the top level to adhere to the principle of least privilege, replacing repository-wide default token write permissions.secrets.CODECOV_TOKEN, so only repository read access is required.Top-Level Concurrency Group with Run-ID Fallback:
main) togithub.run_idso that queued runs onmainare never dropped or superseded.Full 40-Character SHA Pinning Across All 7 Action References:
checks,demo, andtest) to immutable 40-character commit SHAs with trailing version comments:actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0(3 occurrences:checks,demo,test)actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0(3 occurrences:checks,demo,test)codecov/codecov-action@0fb7174895f61a3b6b78fc075e0cd60383518dac # v5.5.5(1 occurrence:checks)demojob (actions/checkoutandactions/setup-node) merged in PR ci: typecheck and build the demo #51..github/dependabot.ymlalready monitors thegithub-actionsecosystem, ensuring Dependabot maintains SHA updates automatically.Verification Results
action-pin -check -dir .github/workflows: Exited 0 (0 unpinned actions).npm ci: Clean install, entry build succeeded.npm test: All 48 Vitest unit tests passed (100% pass).npm run typecheck: 0 TypeScript compiler errors.npm run lint: 0 ESLint / Prettier code style errors.