chore: ignore foreign lockfiles and add packageManager configuration - #80
Closed
sonusharma6-dsa wants to merge 1 commit into
Closed
sonusharma6-dsa wants to merge 1 commit into
sonusharma6-dsa wants to merge 1 commit into
Conversation
|
@sonusharma6-dsa is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing this PR as maintainers indicated on #53 that the repo should not be made npm-only or ignore pnpm-lock.yaml. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
Summary
This PR addresses lockfile hygiene by preventing non-npm lockfiles from cluttering working trees and enforcing
npmas the package manager across the repository:bun.lock,bun.lockb,pnpm-lock.yaml,yarn.lock) to.gitignore."packageManager": "npm@10.8.2"in rootpackage.jsonanddemo/package.jsonto enable Corepack enforcement.CONTRIBUTING.mdto explicitly specifynpmas the required package manager.Testing
48/48tests passing).npm run lintandnpm run typecheckpass cleanly.