Skip to content

chore: ignore foreign lockfiles and add packageManager configuration - #80

Closed
sonusharma6-dsa wants to merge 1 commit into
unlayer:mainfrom
sonusharma6-dsa:fix/lockfile-hygiene-45
Closed

sonusharma6-dsa wants to merge 1 commit into
unlayer:mainfrom
sonusharma6-dsa:fix/lockfile-hygiene-45

Conversation

@sonusharma6-dsa

Copy link
Copy Markdown

Fixes #45

Summary

This PR addresses lockfile hygiene by preventing non-npm lockfiles from cluttering working trees and enforcing npm as the package manager across the repository:

  • Added foreign lockfiles (bun.lock, bun.lockb, pnpm-lock.yaml, yarn.lock) to .gitignore.
  • Added "packageManager": "npm@10.8.2" in root package.json and demo/package.json to enable Corepack enforcement.
  • Updated CONTRIBUTING.md to explicitly specify npm as the required package manager.

Testing

  • Verified all tests pass (48/48 tests passing).
  • Verified npm run lint and npm run typecheck pass cleanly.

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

@sonusharma6-dsa is attempting to deploy a commit to the Unlayer Team on Vercel.

A member of the Team first needs to authorize it.

@sonusharma6-dsa

Copy link
Copy Markdown
Author

Closing this PR as maintainers indicated on #53 that the repo should not be made npm-only or ignore pnpm-lock.yaml. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lockfile hygiene: nothing ignores or rejects non-npm lockfiles

1 participant