Skip to content

security: gate npm publish behind approval + add provenance (C2) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ardiyu07 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

security: gate npm publish behind approval + add provenance (C2) #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
types: [published]
workflow_dispatch:

# 既定は読み取りのみ。publish ジョブでのみ昇格させる（upbond-executives#46 / C2）
permissions:
contents: read

jobs:
build:
runs-on: ubuntu-latest
Expand All @@ -22,6 +26,13 @@ jobs:
publish-npm:
needs: build
runs-on: ubuntu-latest
# 人手 publish を禁止し、承認ゲートを通した CI からのみ publish する。
# environment 側で required reviewers を設定すること（設定は GitHub UI / org-admin）。
environment: npm-publish
permissions:
contents: read
# provenance（来歴証明）の署名に必要。npm の Trusted Publisher 設定とも対になる。
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -36,6 +47,6 @@ jobs:
VERSION=$(node -p "require('./package.json').version")
if [[ "$VERSION" == *"-"* ]]; then TAG=rc; else TAG=latest; fi
echo "Publishing $VERSION with dist-tag $TAG"
npm publish --access public --tag "$TAG"
npm publish --access public --provenance --tag "$TAG"
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}