Repository navigation
Do not rely on short (8+3) names on Windows - #33
Merged
Merged
Conversation
Short names are not created by default on newer versions of Windows. - win32_space_be_gone returns the original path unchanged when no short name without spaces is available, and docs say so. - The test suite quotes paths with spaces instead of shortening them, and uses a forward-slash path to corpus/true.ps1 off of MSWin32. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
plicease
force-pushed
the
graham/no-short-names
branch
from
October 7, 2026 15:57
3da7fe1 to
ddf53b7
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13, fixes #28.
Short (8+3) names are not created by default on newer versions of Windows, so neither the module nor its tests should depend on them.
Library
win32_space_be_gonereturns the original path unchanged when no short name without spaces is available. Previously it returned whateverWin32::GetShortPathNamegave back (the long path, or undef for a path that doesn't exist).set_alias.Tests
t/lib/TestLib.pmno longer shortens the temp dir. It quotes paths in the generated scripts (cmd, PowerShell, Unix) and in the commands that run them.corpus/true.ps1off MSWin32, so/bin/shdoesn't eat the backslash (thettrue.ps1/corpustrue.ps1errors in Possible quoting issue with power shell on windows breaks test #13 and test failures under WSL #31).alias_array.tno longer shortens the perl path; the array form quotes each word.alias.t(string form, where quoting is up to the caller) skips when the perl or script path contains a space;alias_array.tcovers that case.space_win32.tchecks for no spaces when short names exist, and for unchanged paths when they don't.Testing
main, that setup fails 8 test files.space_win32.tneed a Windows run.🤖 Generated with Claude Code