feat: add Go table output compatible with the legacy CLI, with browser-like column widths

[pjcdawkins]

Adds internal/table, a Go equivalent of the legacy Table service, as a building block for moving list/info commands to Go (starting with auth:info). Also changes how the legacy AdaptiveTable picks column widths, so that both CLIs wrap tables the same way.

Go table package

• Table.AddFlags registers --format, --columns/-c and --no-header with the legacy descriptions. -c is skipped if the shorthand is taken.
• Column selection supports repeated or comma/whitespace-separated values, %/* wildcards and + for the default columns, with the legacy Column not found and Invalid format errors.
• csv, tsv and plain output matches the legacy PHP Table byte for byte (compared by running both on the same data), with ANSI escape sequences removed.
• The table format uses the Symfony default border style and wraps cells to the terminal width. Headers and NoWrap columns aren't wrapped.
• ANSI-styled cells are measured with charmbracelet/x/ansi. Styles and OSC 8 hyperlinks still open at the end of a cell's line are closed and re-opened on the next line, so they don't leak into borders or other cells.
• RenderProperties covers the legacy renderSimple (Property/Value table).

Column widths (PHP and Go)

The legacy AdaptiveTable gave every column a fixed 10-character minimum, so it cut words even when the table could fit. Both sides now work more like a browser's automatic table layout:

• A column's minimum width is its longest word plus any indentation, capped at 20. If the minimums don't fit, the cap is reduced down to 10.
• Space above the minimums is shared in proportion to each column's maximum minus minimum width, with integer arithmetic so PHP and Go agree.
• Go wraps with a port of PHP's wordwrap() (measuring display width and keeping ANSI sequences). It matched PHP on 100,000 random inputs, and the Go and PHP tables were identical in 410 generated cases.

This changes the wrapped table output of legacy commands. Two integration tests with wrapped tables at 120 columns were updated.

Not included: value formatting (PropertyFormatter, --date-fmt), table separator rows, and the deprecated-column helpers.

🤖 Generated with Claude Code

[upsun-dispatch]

Warning

Changes suggested — 🟡 2 warnings · ⚪ 1 nitpick

🔍 Full review · 6 files reviewed

⚪ Nitpick

• internal/table/table.go:110 — When two columns share a lower-cased name, indexes keeps the first column (if _, ok := indexes[name]; !ok). The legacy availableColumns overwrites with the last key ($availableColumns[strtolower($columnName)] = $key). Selecting that name therefore shows a different column's data than the legacy CLI does, which contradicts the parity goal.

Verification

• csvCell quotes on ", \n and the delimiter before normalizing \R breaks, the same order as legacy Csv::formatCell with an LF line break.
• plainCell uses the same [\r\n\t]+ → space replacement as legacy PlainFormat::formatCell.
• splitColumns applies the + separation regexes only when exactly one value is given, matching legacy specifiedColumns.
• wrapCell adds the leading indent to every wrapped line, matching legacy AdaptiveTable's preg_replace('/^/m', $indent, ...).
• sgrResets skips the 2 or 4 sub-parameters of 38/48/58 extended colors, so 38;5;0 and 38;2;0;0;0 are not treated as resets.

The new internal/table/table_test.go covers the formats, column selection, wrapping and style isolation. Nothing covers DefaultColumns names that match no column, duplicate column names, or non-SGR escape sequences. I wrote a throwaway test against the package to reproduce the first two findings; the repository's own test target (make test / go test ./...) runs the new tests.

Review details

• Commit: a8d8b2b
• Model: claude-opus-5-5

---

Review 1 of 10 for this pull request · View the full run

Superseded: the latest Upsun Dispatch review no longer requests changes.

[upsun-dispatch]

📋 PR Summary

This PR adds internal/table, a Go version of the legacy PHP Table service. It supports --format, --columns and --no-header, and its csv/tsv/plain/table output matches the legacy CLI. It also changes how both the PHP AdaptiveTable and the Go table pick column widths: they now work more like a browser's automatic table layout, so the two CLIs wrap tables the same way. The latest push caps a cell's minimum width at the cell's own width, so an indented first line followed by a longer unindented line can't make the column wider than its content. It also guards against an out-of-range index in the Go noWrap lookup.

Changes

Layer / File(s)	Summary
Go table package
internal/table/table.go	Adds the Table type with flag registration, column selection (wildcards, + for the default columns) and the csv/tsv/plain formats.
internal/table/render.go	Renders the table format with Symfony-style borders, keeps ANSI styles and OSC 8 links intact across wrapped lines, and adds RenderProperties for Property/Value tables.
internal/table/adaptive.go	Computes adaptive column widths and wraps cells with a port of PHP's wordwrap(). A cell's minimum width is now capped at its own width, and the noWrap lookup is bounds-checked.
internal/table/table_test.go	Tests flags, formats, width allocation and wordwrap. Adds a test for multiline indented cells that checks the output stays within the maximum width.
Legacy column widths
legacy/src/Console/AdaptiveTable.php	Replaces the fixed 10-character minimum with minimums based on each column's longest word (capped at 20, reduced down to 10 if needed) and shares the remaining space proportionally. Each cell's word width is now capped at the cell's width.
legacy/tests/Console/AdaptiveTableTest.php	Updates the width tests and adds a test for a multiline indented cell.
Integration and housekeeping
integration-tests/activity_list_test.go	Updates the expected wrapped table output to the new widths.
integration-tests/environment_deploy_test.go	Updates the expected wrapped table output to the new widths.
go.mod	Changes the dependency declaration for charmbracelet/x/ansi.
CLAUDE.md	Adds contributor notes.

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning

🔁 Incremental · 6 files reviewed

Verification

• flexTotal is always positive in the share step: the early returns guarantee maxTotal > available > minTotal.
• The new wordwrap cuts a too-wide grapheme only once cur > lastStart, so a wide character at a line start cannot loop or produce an empty line.
• wrapCell and longestWordWidth both treat only leading ASCII spaces as indentation, and tabs are expanded in renderTable before either runs.
• Both column-lookup paths in Render (the row filter and noWrap) now check the indexes key exists, and duplicate names map to the last column.

This change updates the unit tests in internal/table/table_test.go: new wrapping cases and TestWordwrap. It also updates legacy/tests/Console/AdaptiveTableTest.php and the expected tables in the integration tests for act and env:deploy. No test covers multi-line indented cells in the width algorithm, where the panic occurs. I reproduced it with a throwaway test.

Review details

• Commits: bb42184..521383a
• Model: claude-opus-5-5

---

Review 3 of 10 for this pull request · View the full run

Superseded: the latest Upsun Dispatch review no longer requests changes.