Fix start&top implementation in typechecker - #2551
DavyLandman wants to merge 8 commits into
Conversation
This reverts commit 8655ee2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
=======================================
- Coverage 45% 45% -1%
+ Complexity 6795 6791 -4
=======================================
Files 843 843
Lines 68828 68828
Branches 10030 10030
=======================================
- Hits 31381 31370 -11
- Misses 35053 35060 +7
- Partials 2394 2398 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
jurgenvinju
left a comment
There was a problem hiding this comment.
Looks good. Needs an integration test.
|
|
@jurgenvinju this is your own code ;) I merely did some git cooking to extract it from a different PR. |
|
@PaulKlint should we use typepal's "predefine" functionality instead of constructing an artificial field location for "top"? Same for the entire start rule. Should we use predefine for that as well? |
70579b4 to
1a8c413
Compare
|
|



This PR continues the work in #2499 (that was merged to main a bit too soon) to fix #2496
start[X]andX(inasubtype,alub,aglb).topcontextFreeSyntaxrole is expected by adding arolefield to thestartATypesyntaxrule forXthat has astartmodifier:start[X] = X;start[X] = X top;start[X] = L X L;isStart*andgetStart*that were used for detecting the old special casesTogether these changes solve a small number of known issues with start symbols, and a larger number of previously undetected issues.