Skip to content

bootstrap PR for syntax role modifiers PR - #2900

Closed
jurgenvinju wants to merge 7 commits into
syntax-role-modifiersfrom
syntax-role-modifiers-boot
Closed

jurgenvinju wants to merge 7 commits into
syntax-role-modifiersfrom
syntax-role-modifiers-boot

Conversation

@jurgenvinju

@jurgenvinju jurgenvinju commented Sep 28, 2026 •

Copy link
Copy Markdown
Member
  • This is a stripped version of syntax role modifiers #1835 to enable a bootstrap of the parser and the checker.

  • This version may produce a RC-BOOT version but it will never be merged. That's for syntax role modifiers #1835

  • uses of the new feature that might get in the way of using the previous version have been removed temporarily.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.98404% with 519 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (7b6b63a) to head (40ea922).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/types/ModifySyntaxRole.java 25% 215 Missing and 30 partials ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java 23% 87 Missing ⚠️
src/org/rascalmpl/types/NamedPlaceholder.java 24% 40 Missing and 3 partials ⚠️
src/org/rascalmpl/library/Type.java 33% 24 Missing ⚠️
src/org/rascalmpl/ast/Type.java 37% 20 Missing ⚠️
src/org/rascalmpl/types/RascalType.java 17% 13 Missing and 1 partial ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java 45% 12 Missing and 1 partial ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java 55% 12 Missing ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java 35% 10 Missing and 1 partial ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java 0% 6 Missing ⚠️
... and 15 more
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #2900    +/-   ##
========================================
- Coverage       45%     45%    -1%     
- Complexity    6798    6859    +61     
========================================
  Files          843     848     +5     
  Lines        68828   69582   +754     
  Branches     10030   10155   +125     
========================================
+ Hits         31384   31673   +289     
- Misses       35055   35474   +419     
- Partials      2389    2435    +46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenvinju
jurgenvinju changed the base branch from main to syntax-role-modifiers September 28, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant