fix(mktemp): add wasi platform support for temporary directory handling - #13786
Open
eduardomourar wants to merge 1 commit into
Open
fix(mktemp): add wasi platform support for temporary directory handling#13786eduardomourar wants to merge 1 commit into
eduardomourar wants to merge 1 commit into
Conversation
eduardomourar
force-pushed
the
fix/mktemp-wasi
branch
from
August 7, 2026 01:22
e7059e9 to
a4d772d
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
- Add conditional compilation for WASI target to avoid panics from `std::env::temp_dir()` - Implement fallback logic in `Options` to read TMPDIR environment variable directly on WASI - Update `get_tmpdir_env_or_default()` with WASI-specific handling for temp directory resolution - Add `#[cfg_attr]` annotations to skip host path-dependent tests on WASI sandbox environment - Ignore 14 tests that require host filesystem access when running under wasi_runner - Ignore directory permission test on WASI due to lack of `chmod` support and mode parameter limitations
eduardomourar
force-pushed
the
fix/mktemp-wasi
branch
from
August 8, 2026 21:50
a4d772d to
d44e481
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::env::temp_dir()Optionsto read TMPDIR environment variable directly on WASIget_tmpdir_env_or_default()with WASI-specific handling for temp directory resolution#[cfg_attr]annotations to skip host path-dependent tests on WASI sandbox environmentchmodsupport and mode parameter limitations