Skip to content

fix: only strip trailing os error suffix - #13816

Open
xtqqczze wants to merge 3 commits into
uutils:mainfrom
xtqqczze:strip_errno
Open

fix: only strip trailing os error suffix#13816
xtqqczze wants to merge 3 commits into
uutils:mainfrom
xtqqczze:strip_errno

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Closes #13723

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/io-errors (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tty-eof (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@sylvestre

Copy link
Copy Markdown
Contributor

how often this happens ?
i already gave my opinion here:
#13723

@xtqqczze

xtqqczze commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

how often this happens ?

Er, I don't know how often this happens. But it still seems like a good idea to ensure that a function documented to "strip the trailing (os error XX)" only strips the trailing occurrence, rather than an occurrence in the middle.

@oech3

oech3 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

I prefer previous code for simplicity until someone find actial issue.

@sylvestre

Copy link
Copy Markdown
Contributor

same, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uucore: strip_errno strips everything after the os error

3 participants