Repository navigation
Conversation
78bc592 to
e065087
Compare
|
Binary size comparison: |
e065087 to
cb695b3
Compare
Merging this PR will degrade performance by 7.88%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_five_38_bit_primes |
1.6 s | 1.8 s | -11.2% |
| ❌ |
Simulation | du_wide_tree[(5000, 500)] |
15.3 ms | 16 ms | -4.44% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:targets-uutests (6f65a3b) with main (7654e67)
Footnotes
-
137 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
a620f78 to
1998905
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1998905 to
ec6fbc2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1068f5e to
b4a3d9a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b4a3d9a to
8ef0b5b
Compare
8ef0b5b to
5e6a95e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5e6a95e to
f6047cb
Compare
Fixes required to build uutils/coreutils on HarmonyOS (aarch64-unknown-linux-ohos): - uucore/fsext: statfs.f_type is u64 on OHOS; route it through the musl branch. - hostid: implement gethostid locally (read /etc/hostid, else hash hostname) because the OHOS SDK libc dropped the symbol. - date: pass through the system time zone ID from OH_TimeService_GetTimeZone and resolve it with embedded IANA tzdata (jiff-tzdb) via TimeZone::tzif, instead of relying on /etc/localtime or a POSIX-injected TZ. The OHOS-only helper is cfg-gated; non-OHOS code paths are byte-identical to upstream. utmpx is intentionally left untouched: upstream uutils#14252 disables it on OHOS (no utmp data source there), and this PR defers to that approach. Also syncs fuzz/Cargo.lock after adding the jiff-tzdb dependency. Verified on-device: date matches system time (+0800 CST; 1987-06-01 -> +0900 CDT), hostid behaves, builds pass on the non-utmpx feature set.
f6047cb to
9ee2a23
Compare
Fixes required to build uutils/coreutils on HarmonyOS (aarch64-unknown-linux-ohos): - uucore/fsext: statfs.f_type is u64 on OHOS; route it through the musl branch. - hostid: implement gethostid locally (read /etc/hostid, else hash hostname) because the OHOS SDK libc dropped the symbol. - date: pass through the system time zone ID from OH_TimeService_GetTimeZone and resolve it with embedded IANA tzdata (jiff-tzdb) via TimeZone::tzif, instead of relying on /etc/localtime or a POSIX-injected TZ. The OHOS-only helper is cfg-gated; non-OHOS code paths are byte-identical to upstream. utmpx is intentionally left untouched: upstream #14252 disables it on OHOS (no utmp data source there), and this PR defers to that approach. Also syncs fuzz/Cargo.lock after adding the jiff-tzdb dependency. Verified on-device: date matches system time (+0800 CST; 1987-06-01 -> +0900 CDT), hostid behaves, builds pass on the non-utmpx feature set.
9ee2a23 to
c1f9d8a
Compare
Head branch was pushed to by a user without write access
c1f9d8a to
1b549be
Compare
1984b63 to
ce61c93
Compare
Fixes required to build uutils/coreutils on HarmonyOS (aarch64-unknown-linux-ohos): - uucore/fsext: statfs.f_type is u64 on OHOS; route it through the musl branch. - hostid: implement gethostid locally (read /etc/hostid, else hash hostname) because the OHOS SDK libc dropped the symbol. - date: pass through the system time zone ID from OH_TimeService_GetTimeZone and resolve it with embedded IANA tzdata (jiff-tzdb) via TimeZone::tzif, instead of relying on /etc/localtime or a POSIX-injected TZ. The OHOS-only helper is cfg-gated; non-OHOS code paths are byte-identical to upstream. utmpx is intentionally left untouched: upstream uutils#14252 disables it on OHOS (no utmp data source there), and this PR defers to that approach. Also syncs fuzz/Cargo.lock after adding the jiff-tzdb dependency. Verified on-device: date matches system time (+0800 CST; 1987-06-01 -> +0900 CDT), hostid behaves, builds pass on the non-utmpx feature set.
ce61c93 to
ff2b18b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
439ceb5 to
8e79705
Compare
8e79705 to
8c9db61
Compare
| rand_chacha = { version = "0.10.0" } | ||
| rayon = "1.10" | ||
| regex = "1.10.4" | ||
| rlimit = "0.11.0" |
There was a problem hiding this comment.
why a new crate? rustix already gives us setrlimit, and we still need rustix process for the other tests
There was a problem hiding this comment.
Without the rlimit switch, uutests would fail to build on Redox, blocking progress toward getting Redox CI working. Since this only affects tests, I don't think the additional dependency is a concern.
|
|
||
| [dependencies] | ||
| ctor = { workspace = true } | ||
| [target.'cfg(not(any(target_os = "aix", target_os = "horizon")))'.dependencies] |
There was a problem hiding this comment.
please split the rlimit switch and the target gating into two PRs
There was a problem hiding this comment.
I have #14739, but that is blocked on Redox CI.
| // For the full copyright and license information, please view the LICENSE | ||
| // file that was distributed with this source code. | ||
|
|
||
| #![cfg(not(any(target_os = "aix", target_os = "horizon")))] |
There was a problem hiding this comment.
why compile the whole crate to nothing on aix/horizon? what fails there?
There was a problem hiding this comment.
nix fails to compile on both:
$ RUSTC_BOOTSTRAP=1 cargo hack clippy -Zbuild-std=std,panic_abort --quiet -p uutests --all-features --lib --target powerpc64-ibm-aix
info: running `cargo clippy -Zbuild-std=std,panic_abort --quiet --all-features --lib --target powerpc64-ibm-aix` on uutests (1/1)
error[E0425]: cannot find type `Pid` in this scope
--> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/nix-0.31.3/src/pty.rs:38:16
|
38 | child: Pid,
| ^^^ not found in this scope
|
help: consider importing this struct
|
3 + use crate::unistd::Pid;
|
$ cargo +nightly hack clippy -Zbuild-std=std,panic_abort --quiet -p uutests --all-features --lib --target armv6k-nintendo-3ds
info: running `cargo clippy -Zbuild-std=std,panic_abort --quiet --all-features --lib --target armv6k-nintendo-3ds` on uutests (1/1)
error[E0432]: unresolved import `self::consts`
--> /Users/matthew/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/nix-0.31.3/src/errno.rs:19:15
|
19 | pub use self::consts::*;
| ^^^^^^ could not find `consts` in `self`049992a to
caba015
Compare
```sh RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std,panic_abort -p uutests --all-features --target=powerpc64-ibm-aix --target=x86_64-linux-android --target=x86_64-pc-cygwin --target=aarch64-apple-darwin --target=x86_64-unknown-freebsd --target=x86_64-unknown-haiku --target=x86_64-unknown-hermit --target=x86_64-unknown-hurd-gnu --target=aarch64-unknown-illumos --target=x86_64-unknown-linux-gnu --target=i686-unknown-netbsd --target=x86_64-unknown-openbsd --target=x86_64-unknown-redox --target=x86_64-pc-solaris --target=wasm32-wasip1 --target=x86_64-pc-windows-gnu ```
caba015 to
6f65a3b
Compare
Closes #14935.