Repository navigation
date: expand GNU-compatible parsing and formatting - #15111
anastygnome wants to merge 1 commit into
Conversation
Merging this PR will degrade performance by 12.58%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | file_custom_format |
30 ms | 36.5 ms | -17.9% |
| ❌ | Simulation | file_iso_dates |
31.5 ms | 38.2 ms | -17.52% |
| ❌ | Simulation | file_localized_names |
41.9 ms | 48.6 ms | -13.73% |
| ❌ | Simulation | file_tz_abbreviations |
35.4 ms | 38.1 ms | -7.07% |
| ❌ | Simulation | complex_relative_date |
292.8 µs | 311.4 µs | -5.97% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing anastygnome:test-util (2b5fe3a) with main (38336e9)
Footnotes
-
444 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
ce6b516 to
2e6eecf
Compare
|
extra work => additional cost. |
|
GNU testsuite comparison: |
|
CICD and Android are related to tail/cp, nothing related to this PR |
|
sorry, but we can't take this: |
|
@sylvestre would making the non debug tests into one PR be ok? |
|
just the tests or tests+fixes? |
|
I mean the code & test that fix tests/date/date & date/date-tz are very similar (I blieve matching debug output isn"t really wise but I had matched it to see if we could and discuss it here |
|
Sure but this pr is huge. I would prefer smaller changes |
ef60759 to
d6ed595
Compare
|
I reduced the scope @sylvestre |
|
@cakebaker @xtqqczze if one od you may review this it'd be appreciated |
cakebaker
left a comment
There was a problem hiding this comment.
I'll likely wrap up the review tomorrow. The tests look fine.
|
No issues, take your time, I'll wait
|
|
@cakebaker thanks, I believe your suggestions make sense. Will implement them shortly. |
| if bytes.get(index) == Some(&b'%') { | ||
| output.push_str("%%"); | ||
| index += 1; | ||
| continue; |
There was a problem hiding this comment.
same flag/width parsing as in substitute_epoch_seconds_value, could be dedup, no?
| | "wednes" | ||
| | "thursday" | ||
| | "thu" | ||
| | "thu." |
There was a problem hiding this comment.
where does this list (wednes, tues, thurs...) come from?
There was a problem hiding this comment.
GNU documents these forms in its "Day of week items" section.
There was a problem hiding this comment.
didn't see the last line there, so I corrected it as well.
|
the patch is still too big |
ef85943 to
c233d2b
Compare
c233d2b to
2b5fe3a
Compare
Handle extended years, GNU debug diagnostics, epoch seconds, normalization, DST gaps, and strftime modifier precedence
refs #14705