Repository navigation
Conversation
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_thirteen_39_bit_primes |
8.7 s | 9.5 s | -9.02% |
| ⚡ | Simulation | factor_three_39_bit_primes |
800.7 ms | 494.1 ms | +62.06% |
| ⚡ | Simulation | factor_five_38_bit_primes |
1.8 s | 1.6 s | +13.27% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing oech3:stty-unsafe (36d4d16) with main (2fb77e8)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
8c0b529 to
39bc936
Compare
ff11e70 to
f100d7d
Compare
|
GNU testsuite comparison: |
9be3124 to
d420658
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Would it be possible to separate the refactor replacing |
|
It is very difficult since |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
a561bf5 to
0ad3f39
Compare
| Flag::new("iutf8", I::IUTF8), | ||
| ]; | ||
|
|
||
| // rustix sometimes not export for macos and musl. use libc as workaround... |
There was a problem hiding this comment.
if you add a workaround for a rustix issue, make sure to open an issue at https://github.com/bytecodealliance/rustix and link it in the comment.
There was a problem hiding this comment.
Actually OLCUC doesn't exist on Apple targets, it was nix mistake...
$ rustc --print host-tuple
aarch64-apple-darwin
$ gstty olcuc
gstty: invalid argument ‘olcuc’There was a problem hiding this comment.
But libc crate has. If it is functional, we could have an extension.
There was a problem hiding this comment.
There was a problem hiding this comment.
$ uu-stty --version
stty (uutils coreutils) 0.12.0
$ uu-stty olcuc
uu-stty: invalid argument 'olcuc'There was a problem hiding this comment.
So we don't lost anything if we removed apple (at here or different PR). OK?
There was a problem hiding this comment.
So we don't lost anything if we removed apple (at here or different PR). OK?
Apparently not:
$ git rev-parse HEAD
2fb77e8b927b5614438d288b0c72827a87106663
uutils-coreutils % cargo run -q --features unix stty olcuc
stty: invalid argument 'olcuc'There was a problem hiding this comment.
Sorry for the confusion, but there is no issue with the PR, I also see the correct stty: invalid argument 'olcuc' error with oech3:stty-unsafe checked out. (when rebased onto #15360)
There was a problem hiding this comment.
It is odd that stty is buildable in any cases.
2ac5fc0 to
36d4d16
Compare
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
rustixmanages baud rate byu32on all platforms. But OS itself should support any baud to actually use any baud. This PR adds support for any baud on Linux kernel (since bsd was already supported atnixcrate).rustixhasu32-> enum decoder.