Skip to content

fix: proper read error for device files with -files0-from - #809

Open
Xylphy wants to merge 2 commits into
uutils:mainfrom
Xylphy:fix-files0-from-device-error
Open

fix: proper read error for device files with -files0-from#809
Xylphy wants to merge 2 commits into
uutils:mainfrom
Xylphy:fix-files0-from-device-error

Conversation

@Xylphy

@Xylphy Xylphy commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #780

The issue this PR referring to is somewhat fixed in main branch but the error message is not matched with GNU find.

GNU find:

$ sudo find -files0-from /dev/vhost-vsock
find: ‘/dev/vhost-vsock’: read error: File descriptor in bad state

Before:

$ sudo find -files0-from /dev/vhost-vsock
find: File descriptor in bad state (os error 77)

The diagnostic was missing the offending file name and the read error: wording, and it carried Rust's (os error N) suffix.

@Xylphy
Xylphy marked this pull request as draft August 4, 2026 14:54
@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing Xylphy:fix-files0-from-device-error (b8239f7) with main (42ddfb1)

Open in CodSpeed

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit 48e6dfe has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +1
  FAILED: +0

New test failures (1):
  - gnu/files0_from_ok

Test improvements (1):
  + gnu/okdir_path_empty

@Xylphy
Xylphy force-pushed the fix-files0-from-device-error branch from 50de4b8 to 5f72426 Compare August 4, 2026 15:15
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit 50de4b8 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 312 / PASSED: 266 / FAILED: 40 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: -1
  PASSED: +0
  FAILED: -1

Test improvements (1):
  + gnu/okdir_path_empty

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit 5f72426 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 266 / FAILED: 42 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +0
  FAILED: +1

New test failures (1):
  - gnu/files0_from_ok

@Xylphy
Xylphy force-pushed the fix-files0-from-device-error branch from 5f72426 to 5a98655 Compare August 4, 2026 15:23
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit 5a98655 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +1
  FAILED: +0

New test failures (1):
  - gnu/okdir_path_relative

Test improvements (1):
  + gnu/okdir_path_empty

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.22%. Comparing base (42ddfb1) to head (b8239f7).

Files with missing lines Patch % Lines
src/find/mod.rs 53.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   92.29%   92.22%   -0.07%     
==========================================
  Files          35       35              
  Lines        7445     7456      +11     
  Branches      388      388              
==========================================
+ Hits         6871     6876       +5     
- Misses        433      439       +6     
  Partials      141      141              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Commit d5dbc2d has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 266 / FAILED: 42 / SKIPPED: 6
  Reference: TOTAL: 313 / PASSED: 266 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +0
  FAILED: +1

New test failures (1):
  - gnu/files0_from_ok

@Xylphy
Xylphy marked this pull request as ready for review August 4, 2026 16:02
@sylvestre

Copy link
Copy Markdown
Contributor

could you please fix the conflict? thanks

@Xylphy
Xylphy marked this pull request as draft August 19, 2026 13:44
@Xylphy
Xylphy force-pushed the fix-files0-from-device-error branch from d5dbc2d to b8239f7 Compare August 20, 2026 05:47
@Xylphy Xylphy changed the title fix: report read error for device files with -files0-from fix: proper read error for device files with -files0-from Aug 20, 2026
@sylvestre

Copy link
Copy Markdown
Contributor

Still draft? :)

@Xylphy
Xylphy marked this pull request as ready for review August 20, 2026 06:03
Copilot AI lite review requested due to automatic review settings August 20, 2026 06:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Xylphy

Xylphy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre Ahh, I'm just waiting for the CI to finish😅

@Xylphy

Xylphy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre I think it's okay to review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(find): when -files0-from is /dev/vhost-net or /dev/vhost-vsock it silences errors

3 participants