fix: proper read error for device files with -files0-from - #809
Open
Xylphy wants to merge 2 commits into
Open
Conversation
Xylphy
marked this pull request as draft
August 4, 2026 14:54
|
Commit 48e6dfe has test result changes: bfs testsuite: |
Xylphy
force-pushed
the
fix-files0-from-device-error
branch
from
August 4, 2026 15:15
50de4b8 to
5f72426
Compare
|
Commit 50de4b8 has test result changes: bfs testsuite: |
|
Commit 5f72426 has test result changes: bfs testsuite: |
Xylphy
force-pushed
the
fix-files0-from-device-error
branch
from
August 4, 2026 15:23
5f72426 to
5a98655
Compare
|
Commit 5a98655 has test result changes: bfs testsuite: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 92.29% 92.22% -0.07%
==========================================
Files 35 35
Lines 7445 7456 +11
Branches 388 388
==========================================
+ Hits 6871 6876 +5
- Misses 433 439 +6
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit d5dbc2d has test result changes: bfs testsuite: |
Xylphy
marked this pull request as ready for review
August 4, 2026 16:02
Contributor
|
could you please fix the conflict? thanks |
Xylphy
marked this pull request as draft
August 19, 2026 13:44
Xylphy
force-pushed
the
fix-files0-from-device-error
branch
from
August 20, 2026 05:47
d5dbc2d to
b8239f7
Compare
Contributor
|
Still draft? :) |
Xylphy
marked this pull request as ready for review
August 20, 2026 06:03
Contributor
Author
|
@sylvestre Ahh, I'm just waiting for the CI to finish😅 |
Contributor
Author
|
@sylvestre I think it's okay to review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #780
The issue this PR referring to is somewhat fixed in
mainbranch but the error message is not matched with GNU find.GNU find:
Before:
The diagnostic was missing the offending file name and the
read error:wording, and it carried Rust's(os error N)suffix.