find: accept egrep and posix-egrep regex types to match GNU - #848
Closed
AlejandroCoronadoN wants to merge 1 commit into
Closed
find: accept egrep and posix-egrep regex types to match GNU#848AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 35 35
Lines 7445 7452 +7
Branches 388 388
=======================================
+ Hits 6871 6878 +7
Misses 433 433
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit 1df2e56 has test result changes: bfs testsuite: |
Contributor
Author
|
Closing this. The bfs test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
findacceptsegrepandposix-egrepas-regextypenames; both select the extended (ERE) syntax. uutils rejects them:They behave identically to the already-supported
posix-extended. Verified against GNU with a+quantifier:egrep,posix-egrepandposix-extendedall match the same paths. This maps both aliases toPosixExtended, mirroring howed/sedalready aliasposix-basic.Left out on purpose: GNU's
awk,gnu-awk,posix-awkandposix-minimal-basichave small semantic differences that the onig syntaxes do not represent exactly, so they are not added here.