find: do not double the "find:" prefix on an invalid -type list - #849
Merged
cakebaker merged 1 commit intoAug 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 35 35
Lines 7445 7445
Branches 388 388
=======================================
Hits 6871 6871
Misses 433 433
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit cdb59b2 has test result changes: bfs testsuite: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
-type/-xtypelist that ends in a comma prints thefind:prefix twice:GNU prints it once:
The message in
type_creatorhardcodes a leadingfind:, but the top level error printer already prependsfind: {e}. The two sibling messages in the same function (the duplicate type and the missing separator ones) do not hardcode it, so this one is inconsistent. Drop the hardcoded prefix so the output matches GNU and the neighbors.