-
Notifications
You must be signed in to change notification settings - Fork 41
fix(relative): add the fraction of a negative relative second count #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Socialpranker
wants to merge
1
commit into
uutils:main
Choose a base branch
from
Socialpranker:fix-negative-fractional-seconds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -280,3 +280,39 @@ fn test_time_seconds_ago_invalid(#[case] input: &str) { | |
| "Input string '{input}' did not produce an error when parsing" | ||
| ); | ||
| } | ||
|
|
||
| // Fractional relative seconds, checked against GNU date 9.11 with | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the header at the top of the file says 8.32, maybe worth aligning the versions to 9.11 |
||
| // TZ=UTC date --date="2026-08-27 12:00:00 <input>" +"%H:%M:%S.%N" | ||
| #[rstest] | ||
| #[case::plus_half("+0.5 sec", "12:00:00.500000000")] | ||
| #[case::minus_half("-0.5 sec", "11:59:59.500000000")] | ||
| #[case::plus_one_and_a_half("+1.5 sec", "12:00:01.500000000")] | ||
| #[case::minus_one_and_a_half("-1.5 sec", "11:59:58.500000000")] | ||
| #[case::plus_quarter("+0.25 sec", "12:00:00.250000000")] | ||
| #[case::minus_quarter("-0.25 sec", "11:59:59.750000000")] | ||
| #[case::plus_one_and_three_quarters("+1.75 sec", "12:00:01.750000000")] | ||
| #[case::minus_one_and_three_quarters("-1.75 sec", "11:59:58.250000000")] | ||
| #[case::plus_two_and_an_eighth("+2.125 sec", "12:00:02.125000000")] | ||
| #[case::minus_two_and_an_eighth("-2.125 sec", "11:59:57.875000000")] | ||
| #[case::minus_nine_nanoseconds("-0.000000009 sec", "11:59:59.999999991")] | ||
| #[case::minus_almost_one("-0.999999999 sec", "11:59:59.000000001")] | ||
| #[case::plus_half_ago("+0.5 sec ago", "11:59:59.500000000")] | ||
| #[case::minus_half_ago("-0.5 sec ago", "12:00:00.500000000")] | ||
| #[case::plus_one_and_a_half_ago("+1.5 sec ago", "11:59:58.500000000")] | ||
| #[case::unsigned_half_ago("0.5 sec ago", "11:59:59.500000000")] | ||
| #[case::unsigned_half("0.5 sec", "12:00:00.500000000")] | ||
| #[case::plus_zero_fraction("+0.0 sec", "12:00:00.000000000")] | ||
| #[case::minus_zero_fraction("-0.0 sec", "12:00:00.000000000")] | ||
| #[case::minus_whole_with_fraction_zero("-1.0 sec", "11:59:59.000000000")] | ||
| #[case::minus_whole("-1 second ago", "12:00:01.000000000")] | ||
| #[case::plural_minus_half("-0.5 seconds", "11:59:59.500000000")] | ||
| #[case::abbreviated_minus_half("-0.5 secs", "11:59:59.500000000")] | ||
| fn test_relative_fractional_seconds(#[case] input: &str, #[case] expected: &str) { | ||
| let base = "2026-08-27 12:00:00" | ||
| .parse::<DateTime>() | ||
| .unwrap() | ||
| .to_zoned(TimeZone::UTC) | ||
| .unwrap(); | ||
|
|
||
| check_time(input, expected, "%H:%M:%S.%N", Some(base)); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 lines of comment for 3 lines of code, nobody will read it :) two lines are enough here