Open
Conversation
danhoeflinger
requested review from
MikeDvorskiy,
SergeyKopienko and
Copilot
and removed request for
SergeyKopienko and
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the set_intersection parallel algorithm to improve efficiency by selecting the optimal trimming strategy (which minimizes total data) and parallelizing along the larger range dimension. The changes affect two implementation files with parallel algorithms for set intersection operations.
Changes:
- Refactored trimming strategy selection to choose the strategy that trims more elements
- Changed parallelization decision to always partition the larger range after trimming
- Changed variable types from
autoto explicitstd::size_tfor size calculations - Simplified cutoff logic to check total work after applying the optimal trimming strategy
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
include/oneapi/dpl/pstl/algorithm_ranges_impl.h |
Updated __pattern_set_intersection to use improved trimming and parallelization logic for ranges-based interface; contains critical bugs in the implementation |
include/oneapi/dpl/pstl/algorithm_impl.h |
Updated __pattern_set_intersection to use improved trimming and parallelization logic for iterator-based interface; complete implementation with minor issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const auto __m2 = __last2 - __left_bound_seq_2 + __n1; | ||
| if (__m2 > __set_algo_cut_off) | ||
| const std::size_t __total_work = __n1 + __n2; |
Contributor
There was a problem hiding this comment.
I think it is rather a common type for _DifferenceType1 and _DifferenceType2.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SergeyKopienko
requested changes
Feb 18, 2026
Contributor
SergeyKopienko
left a comment
SergeyKopienko
left a comment
There was a problem hiding this comment.
I think make sense also to think about __set_union_construct calls too.
Contributor
Author
I created an issue, Id rather deal with them independently. |
akukanov
reviewed
Feb 23, 2026
akukanov
reviewed
Feb 26, 2026
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Co-authored-by: Sergey Kopienko <sergey.kopienko@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
force-pushed
the
dev/dhoeflin/fix_set_intersection_logic
branch
from
7516458 to
2427032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the
set_intersectionparallel algorithm logic to be more efficient and correct when selecting which input range to partition.Now we select the trimming strategy which minimizes the total data and always parallelize along the larger dimension.
This logic was oddly configured previously.