feat: add elevation support to export#405
Open
a-y-a-n-das wants to merge 3 commits intovalhalla:masterfrom
Open
feat: add elevation support to export#405a-y-a-n-das wants to merge 3 commits intovalhalla:masterfrom
a-y-a-n-das wants to merge 3 commits intovalhalla:masterfrom
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/405 |
nilsnolde
requested changes
Mar 29, 2026
Member
There was a problem hiding this comment.
A bunch of things are not good tbh:
- the UI is not up to my standards, looks & feels really odd
- this PR breaks the routing logic: if the page is freshly reloaded and we add 2 waypoints in the map it won't auto-request the route, which it needs to do obviously
- doing another /route request is way too heavy! I know this feature will hardly be ever used by people, so in practice it doesn't matter much. it's just a good principle to not waste any byte & CPU cycle. use /height instead, that's pretty much for free.
Contributor
Author
|
Yes, sirrr
I will try to use that and touch up the UI. |
b8771b4 to
8b192e0
Compare
Contributor
Author
Now using |
Contributor
Author
|
Please let me know if any further changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🛠️ Fixes Issue
feat: Add option to include elevation for download
Closes #211
👨💻 Changes proposed
buildDirectionRequestto includeelevations.useDirectionQueryto accept a prop for the same and return directions withelevations.elevation_interval: 30before downloading.📄 Note to reviewers
AI: used for generating tests.
📷 Screenshots