feat(isNumeric): add support for thousand separator option - #2711
Open
PepiPetrov wants to merge 7 commits into
Open
feat(isNumeric): add support for thousand separator option#2711PepiPetrov wants to merge 7 commits into
PepiPetrov wants to merge 7 commits into
Conversation
Validate options.thousands_separator value
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2711 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2611 +24
Branches 656 660 +4
=========================================
+ Hits 2587 2611 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
tux-tn
requested changes
Jul 25, 2026
tux-tn
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution and for taking the time to work on the old PR. I added some code recommendations in my review but I have also a general concern about the thousands_separator value. As discussed in the original PR (#1476), , I agree on limiting its value to a list of standard separators like comma, dot, space and underscore.
Co-authored-by: Sarhan Aissi <github@tux.tn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1433 and resolves merge conflicts of #1476 .
Checklist