Repository navigation
HTTP downloads: no overall time limit - #64
Merged
Merged
Conversation
Collaborator
Author
|
Simple fix should be short |
ivorbosloper
force-pushed
the
download-timeout
branch
from
October 29, 2026 19:23
c6ed45b to
cac1769
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new timeout policy and FSTimeoutError handling lack regression tests for timeout values, explicit timeout preservation, URI-bearing errors, and partial-file cleanup.
1 open issue
What changed in this PR
This PR allows large HTTP downloads to run beyond five minutes while retaining an inactivity timeout, addressing failures such as Bavaria’s 5.7 GB dataset download.
Changes:
- Remove the default overall HTTP timeout; set connection and read-inactivity limits to 60 and 300 seconds, respectively.
- Add the download URI to timeout errors while preserving partial-file cleanup.
- Document the download timeout change in the changelog.
| File | Description |
|---|---|
vecorel_cli/vecorel/util.py |
Configure HTTP timeout defaults while preserving explicit caller timeouts. |
vecorel_cli/conversion/base.py |
Convert filesystem timeout errors into URI-bearing download errors. |
CHANGELOG.md |
Add an unreleased entry for the timeout change. |
Review effort: Balanced
m-mohr
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

HTTP downloads stop after five minutes in total, this makes Bavaria's 5.7 GB
landnutzung.gpkgfail. Now the download stops if the bytes have stopped streaming for 5 minutes.