Skip to content

HTTP downloads: no overall time limit - #64

Merged
ivorbosloper merged 1 commit into
mainfrom
download-timeout
Oct 30, 2026
Merged

ivorbosloper merged 1 commit into
mainfrom
download-timeout

Conversation

@ivorbosloper

@ivorbosloper ivorbosloper commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

HTTP downloads stop after five minutes in total, this makes Bavaria's 5.7 GB landnutzung.gpkg fail. Now the download stops if the bytes have stopped streaming for 5 minutes.

@ivorbosloper

ivorbosloper commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

Simple fix should be short

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new timeout policy and FSTimeoutError handling lack regression tests for timeout values, explicit timeout preservation, URI-bearing errors, and partial-file cleanup.

1 open issue
What changed in this PR

This PR allows large HTTP downloads to run beyond five minutes while retaining an inactivity timeout, addressing failures such as Bavaria’s 5.7 GB dataset download.

Changes:

  • Remove the default overall HTTP timeout; set connection and read-inactivity limits to 60 and 300 seconds, respectively.
  • Add the download URI to timeout errors while preserving partial-file cleanup.
  • Document the download timeout change in the changelog.
File Description
vecorel_cli/​vecorel/​util.py Configure HTTP timeout defaults while preserving explicit caller timeouts.
vecorel_cli/​conversion/​base.py Convert filesystem timeout errors into URI-bearing download errors.
CHANGELOG.md Add an unreleased entry for the timeout change.

Review effort: Balanced

Comment thread vecorel_cli/vecorel/util.py Resolved
@ivorbosloper
ivorbosloper merged commit 350b60b into main Oct 30, 2026
8 checks passed
@ivorbosloper
ivorbosloper deleted the download-timeout branch October 30, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants