You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added PerFileConverterMixin: converts each source on its own into a temporary part and merges the parts with merge_parquet.
Added get_input_urls() to BaseConverter, used by both converters, so the mixin resolves the sources once and logs the input/variant warnings once instead of per part.
Tests for the merge of two sources (incl. constants that differ per part becoming a column) and for a single source.
… it isn't fiboa-specific and builds on `merge_parquet`.
- Added `PerFileConverterMixin`: converts each source on its own into a temporary part and merges the parts with `merge_parquet`.
- Added `get_input_urls()` to `BaseConverter`, used by both converters, so the mixin resolves the sources once and logs the input/variant warnings once instead of per part.
- Tests for the merge of two sources (incl. constants that differ per part becoming a column) and for a single source.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Multi-source conversions requesting Brotli compression fail during merging on allowed DuckDB 1.4 versions, so intermediate files and merges need a supported codec before Arrow applies the requested output compression.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Brotli compression fails during multi-source DuckDB merge
vecorel_cli/conversion/per_file.py:43
For multi-source conversions, forwarding compression="brotli" to the merge fails after the parts have been converted: DuckDB 1.4, which the dependency constraint allows, cannot write Brotli-compressed Parquet. Use a DuckDB-supported codec for the intermediate parts and merge, then apply the requested output codec with the Arrow postprocessor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PerFileConverterMixin: converts each source on its own into a temporary part and merges the parts withmerge_parquet.get_input_urls()toBaseConverter, used by both converters, so the mixin resolves the sources once and logs the input/variant warnings once instead of per part.