feat(http): migrate ClickHouse sink to Hyper 1 - #26157
Merged
Merged
Conversation
pront
marked this pull request as ready for review
August 19, 2026 19:29
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Aug 25, 2026
13 tasks
thomasqueirozb
approved these changes
Aug 31, 2026
…comb # Conflicts: # src/sinks/clickhouse/config.rs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
pront
enabled auto-merge
August 31, 2026 20:50
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The HTTP v1 migration needs a real production sink caller so the native client can be validated beyond isolated transport tests. This PR migrates the ClickHouse sink, which has Docker-backed integration coverage, while keeping the existing request, retry, delivery, and internal telemetry contracts.
The earlier Honeycomb migration is reverted in this PR's history; Honeycomb remains on the existing client. No configuration surface is added, and the migration is limited to ClickHouse so behavior can be compared against the released binary before more sinks move.
Changes
References
httpcrate to version 1.0.0 #19179 (comment)Vector configuration
No production configuration changes. The exact YAML used for the local A/B comparison was:
The same configuration was run against a deterministic local mock ClickHouse endpoint with the custom branch binary and the released Vector 0.57.0 binary.
How did you test this PR?
cargo test -p vector sinks::clickhouse --lib -- --test-threads=1(40 passed)cargo test -p vector http::transport_tests --lib -- --test-threads=1(26 passed)FEATURES='default,rdkafka/dynamic-linking' make check-clippymake check-events(0 errors)SELECT 1healthcheck and one ClickHouseJSONEachRowevent batch;receivedEventsTotal=1,sentEventsTotal=1, andsentBytesTotal=119for the ClickHouse sink;The A/B comparison exposed one expected wire-level difference for follow-up: the custom client sends
Accept-Encoding: identity, while Vector 0.57.0 advertiseszstd,gzip,deflate,br. User-agent differences are expected because the binaries have different versions.Is this a breaking change?
Does this PR include user facing changes?
Contributor Guidelines
make fmtmake check-clippy(auto-fix withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory (https://github.com/vectordotdev/vrl/blob/main/LICENSE-3rdparty.csv) and commit the changes (if any). More details on the dd-rust-license-tool (https://crates.io/crates/dd-rust-license-tool).