fix(auth): authorize legacy bank writes before provisioning - #3095
Open
r266-tech wants to merge 1 commit into
Open
fix(auth): authorize legacy bank writes before provisioning#3095r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal_id+updated_atcompare-and-setFixes #3036.
Tests
git diff --checkReview note
Adversarial review was reworked across several rounds: the final patch adds compatibility-safe preauthorization, row locking, zero-row detection, a locked response snapshot, post-commit config fallback, and portable stale-write protection for PostgreSQL and Oracle.
The remaining review concern is the repository's existing connection-bound provisioning contract:
HINDSIGHT_API_DEFAULT_BANK_TEMPLATEis best-effort, opens separate connections, and therefore runs after the caller transaction commits usingbank_id. Fully lifecycle-binding every template resource write would require a broader provisioning-state design; this PR preserves the explicit contract described in_ensure_bank_exists()and issue #3036 rather than expanding that architecture.