Skip to content

fix: pid reuse after reboot, missing pid in instance.json, Windows non-ASCII locale #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoloboschi merged 2 commits into from
Sep 14, 2026
Merged

fix: pid reuse after reboot, missing pid in instance.json, Windows non-ASCII locale #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2619f6
fix: verify saved pid is a live postgres; tolerate missing pid; C loc…
nicoloboschi Sep 14, 2026
fc239c2
test: unit tests for every pid/locale change; run cargo test in CI
nicoloboschi Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
- name: Build
run: cargo build --release

- name: Unit tests
run: cargo test --release

- name: Upload CLI artifact
uses: actions/upload-artifact@v4
with:
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to pg0 are documented in this file.

## [Unreleased]

### Fixed

- `start`, `stop`, and `drop` no longer trust a saved pid that the OS reused after a reboot; a pid only counts as running if it matches `postmaster.pid` and is a live postgres process. This fixes a permanent "Instance already running" refusal and prevents `stop` from signalling an unrelated process (#37).
- `instance.json` without a `pid` (or with `null` / `0`) no longer breaks `start` (#36).
- New Windows clusters are initialized with `--locale=C`, so `initdb` no longer fails on localized locale names such as `Turkish_Türkiye.1252` (#35). Existing data directories are unchanged.

## [0.15.1] - 2026-07-31

### Fixed
Expand Down
Loading
Loading