Skip to content

Keep properties untyped code adds to typed object literals - #1733

Merged
ctate merged 2 commits into
mainfrom
ctate/keep-properties-untyped-47e594
Oct 22, 2026
Merged

ctate merged 2 commits into
mainfrom
ctate/keep-properties-untyped-47e594

Conversation

@ctate

@ctate ctate commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator
  • A typed object literal passed to untyped JavaScript keeps the properties that code adds, so JSON.stringify, Object.keys and console.log see them, as in Node
  • JSON.stringify of such records writes integer keys first, in Node's own-key order
  • pnpm bench:runtime vs main: neutral (geomean -0.1%)

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
scriptc Ready Ready Preview, v0 Oct 22, 2026 3:02am UTC

Comment thread packages/runtime/src/scr_json.c Outdated
@ctate
ctate merged commit e80be9c into main Oct 22, 2026
23 checks passed
@ctate
ctate deleted the ctate/keep-properties-untyped-47e594 branch October 22, 2026 03:06

This branch was successfully deployed

1 active deployment
Preview — 71d5e92d Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant