Repository navigation
chore: align Node 22 pin and Corepack CI with current vis.gl projects - #19
Conversation
- Bump Volta pin from 18.19.0 to 20.18.0 - Update engines field from >= 18 to >= 20 in all three modules - Update CI: node-version matrix to [20], checkout@v4, setup-node@v4 with built-in yarn cache (replaces deprecated c-hive/gha-yarn-cache), coverallsapp/github-action@v2 https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
- Add .nvmrc pinned to 20.18.0 - Replace volta field with "packageManager": "yarn@1.22.19" in package.json - Update CI workflow to read node version from .nvmrc and enable corepack https://claude.ai/code/session_0142Pmpg2JL4V53HGuU7tasX
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| cache: 'yarn' | ||
|
|
||
| - name: Enable corepack | ||
| run: corepack enable yarn |
There was a problem hiding this comment.
Corepack must be enabled before setup-node caching
High Severity
The corepack enable yarn step runs after actions/setup-node@v4 with cache: 'yarn', but setup-node needs yarn to be available at its execution time to resolve the cache directory. Since package.json now declares "packageManager": "yarn@1.22.19", the setup-node action expects corepack to already be enabled to locate the correct yarn binary for caching. This ordering will cause the CI workflow to fail. The corepack enable step needs to be placed before the setup-node step.
Additional Locations (1)
Coverage Report for CI Build 37129388636Coverage remained the same at 60.222%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |


Align local development and CI on Node 22.22.1 via
.nvmrc, replacing the original Node 20 proposal after comparison with current loaders.gl, luma.gl, and deck.gl..nvmrc.fileinput for the generated LCOV report.Comparison sources:
Validation on Node 22.22.1 and Yarn 4.18.0:
yarn install --immutableyarn bootstrap(including package builds)yarn lintyarn cover: 9 files / 22 tests passedyarn test-headless: 1 file / 2 tests passedgit diff --checkExisting peer-dependency and build/Vitest warnings remain; all listed checks passed.