feat(core): Select and Link components for json-render - #508
Merged
Conversation
Adds a popover-based Select (built on FloatingPopover, with optional substring search) and a Link component with a scheme allowlist (http/https/mailto) since specs can be streamed/model-generated and the client can run embedded in a host page. Also implements TextInput's `type` and `loading` props, which were already documented and in the upstream base-catalog schema but not wired up. FloatingPopover gains `panelClass`, `ignore` (so a toggle trigger doesn't immediately reopen its own popover), and ancestor-scroll repositioning, plus a fix so the very first open of a wide, unmeasured panel doesn't animate a positional wobble between the centered-transform guess and the corrected absolute position.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selectcomponent (popover listbox built on the existingFloatingPopover, with optional substring search) and aLinkcomponent (with an http/https/mailto scheme allowlist, since specs can be streamed/model-generated and the client can run embedded in a host page).TextInput'stypeandloadingprops — already documented and in the upstream base-catalog schema, but not wired up.FloatingPopoverwithpanelClass,ignore(so a toggle trigger doesn't immediately reopen its own popover), ancestor-scroll repositioning, and a fix for a positional wobble on the first open of a wide, unmeasured panel.Screenshots