Repository navigation
New package: dysk-3.7.1 - #57959
New package: dysk-3.7.1#57959yabobay wants to merge 1 commit into
Conversation
|
Btw, please don't send PRs from your master branch, the branch name should contain the package name, e.g. |
|
I'm personally using duf which we've already packaged which is very similar, is there any advantage of |
|
I'm aware of the master branch thing, i just kinda... slipped up this time. If i'm gonna submit another package sometime, i'll probably just delete my fork and make a new one and do that next time.
Well i wasn't aware of duf but i just tried it, i think i still prefer dysk though for its smaller output by default, plus it doesn't even do the visual usage indicator on a default-sized terminal. It's also packaged in a few distros already so it feels like kind of a reasonable addition. |
e82b6f8 to
8081d77
Compare
We don't care from what branch you initiate a pull request. If you want to use your own master, go right ahead, just know that it will complicate your workflow if you ever have more than one contribution in flight. If you do prefer to use a new branch, the name is arbitrary and unimportant to us. |
|
For some reason the template didn't have |
|
Not sure what to do about the failing check |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Bump. I just tested the package and it works. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Bump. |
Duncaen
left a comment
There was a problem hiding this comment.
diff --git a/srcpkgs/dysk/template b/srcpkgs/dysk/template
index 8b326c3936c..cf6f73cab90 100644
--- a/srcpkgs/dysk/template
+++ b/srcpkgs/dysk/template
@@ -13,10 +13,9 @@ checksum=a712ce25f8c5867a29b699e5e22fed58b8884fb7ca112f01845c7a99b111dce5
post_install() {
vlicense LICENSE
- vdoc README.md
- out_dir=$(find target -type f -name dysk.bash -exec dirname {} \;)
- vcompletion $out_dir/dysk.bash bash
- vcompletion $out_dir/dysk.fish fish
- vcompletion $out_dir/_dysk zsh
- vman $out_dir/dysk.1
+ local _out_dir=$(echo "target/${RUST_TARGET}/release/build/dysk-"*/out)
+ vcompletion "${_out_dir}/dysk.bash" bash
+ vcompletion "${_out_dir}/dysk.fish" fish
+ vcompletion "${_out_dir}/_dysk" zsh
+ vman "${_out_dir}/dysk.1"
}And please squash the commits.
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing