marisa: update to 0.3.1.#61278
Merged
Merged
Conversation
Duncaen
requested changes
Jun 28, 2026
| build_style=gnu-configure | ||
| hostmakedepends="autoconf automake libtool" | ||
| build_style=cmake | ||
| configure_args="-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX=/usr -DENABLE_NATIVE_CODE=OFF -DBUILD_TESTING=OFF" |
Member
There was a problem hiding this comment.
Remove CMAKE_BUILD_TYPE which is set to none so that xbps-src cflags are used and CMAKE_INSTALL_PREFIX because that is already set too.
void-packages/common/build-style/cmake.sh
Lines 56 to 57 in 63c263f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Reason for this update
The previous template for
marisa(0.2.6) explicitly hardcoded--enable-popcntin its configure arguments forx86_64. This caused anIllegal instructioncrash on older x86_64 CPUs that lack native SSE4.2POPCNTsupport (such as the Intel Core 2 Duo P8600).This PR updates
marisato0.3.1, which migrates the build system from Autotools to CMake. By adopting the new version and keeping-DENABLE_NATIVE_CODE=OFF, the problematic hardcodedpopcntflag is safely dropped..