clevis: update to 23#61296
Open
louiszn wants to merge 1 commit into
Open
Conversation
Duncaen
requested changes
Jun 29, 2026
Member
There was a problem hiding this comment.
- Set
b_ndebug=falsebecause Clevis 23'stest-token-to-jweusesassert(). With Void's defaultb_ndebug=true,NDEBUGis defined, the assertions are compiled out, and the test fails to build under-Werrordue to unused variables.
Wouldn't it be better to fix the patch instead or disable -Werror?
| version=23 | ||
| revision=1 | ||
| # Holds non-standard upstream version suffixes when needed. | ||
| _subversion=tpm1u1 |
Member
There was a problem hiding this comment.
Where does this suffix come from?
Duncaen
reviewed
Jun 29, 2026
| homepage="https://github.com/latchset/clevis" | ||
| distfiles="https://github.com/latchset/clevis/archive/v$version/clevis-$version.tar.gz" | ||
| checksum=67eb9cbbb9c90f9802cae76503f74f23d0046ee6570553407035e9fae3b4b4dd | ||
| distfiles="https://github.com/latchset/clevis/archive/v${version}${subversion}/clevis-${version}${subversion}.tar.gz" |
Member
There was a problem hiding this comment.
This doesn't actually use the suffix you added. The variable is _subversion, not subversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Additional testing:
clevisto 23.systemd-reply-passwordat build time on non-systemd systemschmodin the dracut module for the password unlocker scriptsb_ndebug=falsebecause Clevis 23'stest-token-to-jweusesassert(). With Void's defaultb_ndebug=true,NDEBUGis defined, the assertions are compiled out, and the test fails to build under-Werrordue to unused variables.chmod: command not foundwarning is gone.