libpisp: update to 1.6.0.#61341
Merged
Merged
Conversation
Contributor
Author
|
One question for maintainers: this package was previously published for x86_64/i686. When restricting archs on an already-distributed package, is there anything to handle on the repo side for the now-obsolete binaries (e.g. do they get cleaned up automatically, or is a manual step / noarch handling needed)? Happy to follow whatever the standard procedure is. |
Member
|
Those need to be manually cleaned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Restricts archs to "aarch64* armv*". I added this package originally without an archs restriction, which was a mistake: PiSP is Raspberry Pi ISP hardware, and libpisp's only consumer in the repo, libcamera, already gates its libpisp-devel dependency to aarch64*/armv* (its rpi/pisp pipeline handler is ARM-only). The library compiles on x86 but has no build-time consumer and no runtime hardware there, so building it for those arches never made sense. This corrects that.
1.6.0 also adds an optional GStreamer plugin (
pispconvert), gated behind thegstreamermeson feature and disabled by default. This template keeps it disabled: the plugin referencesGST_VIDEO_FORMAT_NV12_128C8andGST_VIDEO_FORMAT_NV12_10LE32_128C8, which are not present in any released GStreamer (absent through the currentmain), so it fails to compile against Void's gstreamer. Those formats come from gstreamer MR !9247 (https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9247), which is still under active review and not yet merged. Carrying it as a downstream patch is not worth it while it keeps moving, so the plugin stays off until the formats land in a gstreamer release.