Repository navigation
fix(multipart): stream part bodies past rejected boundary prefixes - #58
Merged
Merged
Conversation
A boundary prefix followed by padding and a non-CRLF byte is body data, but the part body generator searched the whole buffer for the next prefix before it yielded anything. A body that repeats such prefixes was held in memory up to the 72 MiB store limit, with a full buffer copy on every 64 KiB read, and the metadata and blob size limits never ran. Yield through the first byte of each rejected prefix before searching again. No delimiter can start earlier, so the yielded bytes are the same; only the chunking changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remote cache stagingCommit: Cloudflare deployment is disabled. Configure the repository secrets and variables described in the e2e plan, then set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A boundary prefix (
\r\n--<boundary>) followed by padding and a byte other than CRLF is body data. The part body generator still searched the whole buffer for the next prefix before it yielded anything. So a store body that repeats such prefixes was held in memory up to the 72 MiB store limit, with a full buffer copy on every 64 KiB read. The metadata (5 MiB) and blob (64 MiB) limits never ran, because they only see yielded chunks. Only an authorized publisher can send a store body.The generator now yields through the first byte of each rejected prefix before it searches again. No delimiter can start earlier, so the stored bytes are the same; only the chunking changes.
🤖 Generated with Claude Code