Repository navigation
Conversation
fengmk2
marked this pull request as ready for review
November 13, 2026 06:13
The staging deploy job excluded fork PRs and Dependabot, but not Renovate, which opens same-repository PRs here. When staging deploys are enabled, a Renovate PR would install newly published packages and actions and run them (tsx, wrangler, setup-vp) with CLOUDFLARE_API_TOKEN in the environment before anyone reviews it. The production workflow reads the same repository secret. Exclude every PR whose author is a bot account, which covers Dependabot, Renovate, and future automation, from the deploy and notify jobs, and say so in the check summary and the e2e plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fengmk2
force-pushed
the
ci/no-cloudflare-secrets-for-bot-prs
branch
from
November 13, 2026 06:43
8c4312f to
c28319c
Compare
Remote cache stagingCommit: Cloudflare deployment is disabled. Configure the repository secrets and variables described in the e2e plan, then set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staging deploy job excluded fork PRs and Dependabot, but not Renovate, which opens same-repository PRs here. When staging deploys are enabled (
REMOTE_CACHE_DEPLOY_ENABLED=true), a Renovate PR installs newly published packages and action pins and runs them (tsx, wrangler, setup-vp) withCLOUDFLARE_API_TOKENin the environment, before anyone reviews the PR.--ignore-scriptsstops install hooks only. The production workflow reads the same repository secret, so that token can change production resources.The deploy and notify jobs now skip every PR whose author is a bot account (
user.type == 'Bot'). This covers Dependabot, Renovate, and future automation. The check summary anddocs/e2e-plan.mdsay so.Staging deploys are disabled today (the deploy job is skipped on current runs), so no Renovate run has received the token yet.
🤖 Generated with Claude Code