Skip to content

ci: keep Cloudflare credentials away from bot-authored PRs - #60

Merged
fengmk2 merged 1 commit into
fix/cleanup-completed-upload-abortfrom
ci/no-cloudflare-secrets-for-bot-prs
Nov 13, 2026
Merged

fengmk2 merged 1 commit into
fix/cleanup-completed-upload-abortfrom
ci/no-cloudflare-secrets-for-bot-prs

Conversation

@fengmk2

@fengmk2 fengmk2 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

The staging deploy job excluded fork PRs and Dependabot, but not Renovate, which opens same-repository PRs here. When staging deploys are enabled (REMOTE_CACHE_DEPLOY_ENABLED=true), a Renovate PR installs newly published packages and action pins and runs them (tsx, wrangler, setup-vp) with CLOUDFLARE_API_TOKEN in the environment, before anyone reviews the PR. --ignore-scripts stops install hooks only. The production workflow reads the same repository secret, so that token can change production resources.

The deploy and notify jobs now skip every PR whose author is a bot account (user.type == 'Bot'). This covers Dependabot, Renovate, and future automation. The check summary and docs/e2e-plan.md say so.

Staging deploys are disabled today (the deploy job is skipped on current runs), so no Renovate run has received the token yet.

🤖 Generated with Claude Code

@fengmk2
fengmk2 added this pull request to stack #62 November 13, 2026 05:31
@fengmk2
fengmk2 marked this pull request as ready for review November 13, 2026 06:13
The staging deploy job excluded fork PRs and Dependabot, but not Renovate,
which opens same-repository PRs here. When staging deploys are enabled, a
Renovate PR would install newly published packages and actions and run them
(tsx, wrangler, setup-vp) with CLOUDFLARE_API_TOKEN in the environment before
anyone reviews it. The production workflow reads the same repository secret.

Exclude every PR whose author is a bot account, which covers Dependabot,
Renovate, and future automation, from the deploy and notify jobs, and say so in
the check summary and the e2e plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fengmk2
fengmk2 force-pushed the ci/no-cloudflare-secrets-for-bot-prs branch from 8c4312f to c28319c Compare November 13, 2026 06:43
@github-actions

Copy link
Copy Markdown

Remote cache staging

Commit: c28319ca308dbe6058a91d7c06089f7ffdb43589

Cloudflare deployment is disabled. Configure the repository secrets and variables described in the e2e plan, then set REMOTE_CACHE_DEPLOY_ENABLED=true and rerun this workflow. No live deployment passed verification.

Manual checks and complete e2e plan.

@fengmk2
fengmk2 merged commit 75b8933 into main Nov 13, 2026
6 of 7 checks passed
@fengmk2
fengmk2 deleted the ci/no-cloudflare-secrets-for-bot-prs branch November 13, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant