Repository navigation
Conversation
fengmk2
marked this pull request as ready for review
November 13, 2026 06:14
fengmk2
commented
Nov 13, 2026
The documented rollback was to re-run an earlier production run. A re-run deploys its original commit, and that commit's .github/production-repositories.jsonc then becomes the live policy: prepare re-enables namespaces that later commits withdrew and restores old pull request opt-ins. For example, a re-run of the 4e92504 deployment would turn pull request uploads back on for void, and only a log line would show it. Fail the production job before checkout when the run's commit is not the current head of main, and document rollback as a revert on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review feedback: the workflow check ran before checkout, install, check, and smoke. If main advanced during those steps, the run still applied the older commit's repository list and pull request opt-ins. Add an optional verify hook to deploy targets. deployTarget calls it before setup changes anything and again just before prepare. The production target compares the run's commit with the current head of main, read from GitHub with git ls-remote. The workflow step stays as an early failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fengmk2
force-pushed
the
ci/production-deploys-main-head-only
branch
from
November 13, 2026 06:43
81767e1 to
a54b03c
Compare
Remote cache stagingCommit: Cloudflare deployment is disabled. Configure the repository secrets and variables described in the e2e plan, then set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented rollback was to re-run an earlier production run. A re-run deploys its original commit, and
productionTarget.preparethen applies that commit's.github/production-repositories.jsoncto production D1. It re-enables namespaces that later commits withdrew, disables namespaces added later, and restores old pull request opt-ins. For example, re-running the4e92504deployment (run 39217251606) would turn pull request uploads back on forvoid, so unreviewed same-repository PR code could publish entries thatvoiddefault-branch builds restore. Only a log line would show it.verifyhook.deployTargetcalls it before setup changes anything and again just beforeprepare.verifycompares the run's commit with the current head ofmain, read from GitHub withgit ls-remote. A run whose commit is not the head, including one wheremainadvanced during check and smoke, stops before it changes production.docs/e2e-plan.mddocuments rollback as a revert onmainfollowed by a new run.A re-run of a run made before this change uses that run's old workflow and scripts, so it is not checked. Don't re-run those runs. GitHub allows re-runs for 30 days, so the
4e92504run stays re-runnable until about 2026-11-18.🤖 Generated with Claude Code