Skip to content

Migration pins lockfile-only package managers and can break CI #2816

Description

@TheAlexLichter

Describe the bug

A project with only a lockfile has no exact package-manager set.
But vp migrate adds an exact devEngines.packageManager declaration.

This can break existing CI before Vite+ runs.

For example, actions/setup-node followed by npm ci may use the npm version bundled with Node, which can differ from the version pinned by the migration.

Ideas for a solution:

  • Keep existing packageManager or devEngines.packageManager declarations.
  • Leave projects without either declaration unpinned (but warn!)
  • Use the package manager resolved from the lockfile only for migration capability checks.
  • Keep explicit version pinning as a separate action (vp env pin)

Reproduction

Steps to reproduce

No response

System Info

-

Used Package Manager

npm

Logs

-

Validations

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Target date

    None yet

    Start date

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions